Release buffer after creating egl image #259

xiaowei-guan · 2022-03-11T12:55:19Z

No need wait for flutter engine destruct callback to destory TBM buffer.

* No need wait for flutter engine destruct callback to destory TBM buffer.

swift-kim · 2022-03-14T02:24:58Z

The release_callback interface has been added to the upstream's FlutterDesktopPixelBuffer (flutter#28298).

Should we update our implementation (FlutterDesktopGPUBufferTextureConfig and FlutterDesktopGpuBuffer) accordingly? It will be a breaking API change and the video_player_tizen plugin will need to be updated as well.

(Please also take a look at Stuart's comment in flutter#28298 (comment) if you're to make the change.)

p.s. FlutterDesktopGPUBufferTextureConfig (capitalized GPU) should also be renamed to FlutterDesktopGpuBufferTextureConfig for consistency.

xiaowei-guan · 2022-03-14T11:18:36Z

The release_callback interface has been added to the upstream's FlutterDesktopPixelBuffer (flutter#28298).

Yes, For the release callback, we can refer to the implementation of pixel buffer. Thanks for your suggestion. I will apply it.

wb0716

Good for me

zhouleonlei

lgtm

swift-kim

Thank you for taking my suggestion into account and the change generally looks good to me.

Will this change require any client side (i.e. camera_tizen and video_player_tizen) changes?

xiaowei-guan · 2022-03-15T05:26:06Z

Thank you for taking my suggestion into account and the change generally looks good to me.

Will this change require any client side (i.e. camera_tizen and video_player_tizen) changes?

Yes, the plugin which uses texture api, need update.

bwikbs · 2022-03-15T06:37:33Z

@xiaowei-guan
I have a question (Plz understand that I have never seen driver behavior or egl extension implementations before..).
I'm not sure because I'm not in the office right now.. so I can't test this with my target...
According to my foggy memory, the reason that destroying tbm is performed in destruciton callback is because this caused a problem in using multiple webviews (like animation or map). And by some inaccurate experiments, I thought that contents of tbm were not copied when creating the egl image.

So..can you explain a little bit more about whether it is safe to create an egl image and delete the tbm right away? 😄

…tter-2.10.1-tizen-texture

xiaowei-guan · 2022-03-17T02:35:41Z

@xiaowei-guan I have a question (Plz understand that I have never seen driver behavior or egl extension implementations before..). I'm not sure because I'm not in the office right now.. so I can't test this with my target... According to my foggy memory, the reason that destroying tbm is performed in destruciton callback is because this caused a problem in using multiple webviews (like animation or map). And by some inaccurate experiments, I thought that contents of tbm were not copied when creating the egl image.

So..can you explain a little bit more about whether it is safe to create an egl image and delete the tbm right away? 😄

I just refer to eglCreateImageKHR API guide, I didn't find need wait for destruction callback, and I have tested with video player plugin. But I didn't test others plugin which use texture. I start to check the soruce code of eglCreateImageKHR,I will reply it later.

xiaowei-guan · 2022-03-22T06:07:24Z

I have a question (Plz understand that I have never seen driver behavior or egl extension implementations before..).
I'm not sure because I'm not in the office right now.. so I can't test this with my target...

@bwikbs
I have downloaded TV GPU driver source code, and add some log. I have tested Video player plugin,there is no problem.
Could you please guide me how to test multiple webviews?

bwikbs · 2022-03-23T06:38:24Z

@xiaowei-guan

Could you please guide me how to test multiple webviews?

Here is sample
Thanks 😄 I'll check it too!

update)
In my case, It works ok at TV. 👍 I guess there is some misunderstanding.
Plz, double check it your side.

xiaowei-guan · 2022-03-24T02:04:19Z

I have run webview plugin sample on TV device,also no problem.

swift-kim · 2022-03-25T02:13:24Z

The client side (camera_tizen and video_player_tizen) changes should be prepared first before we can publish this change.

xiaowei-guan · 2022-03-25T06:33:15Z

Video player plugin

[video_player] Apply new texture release callback plugins#344

swift-kim

Thank you!

This reverts commit f1e1b01.

* Release buffer after creating egl image * No need wait for flutter engine destruct callback to destory TBM buffer. * Apply common release callback

xiaowei-guan requested a review from a team March 11, 2022 12:55

Release buffer after creating egl image

68b70e8

* No need wait for flutter engine destruct callback to destory TBM buffer.

wb0716 approved these changes Mar 15, 2022

View reviewed changes

zhouleonlei approved these changes Mar 15, 2022

View reviewed changes

swift-kim reviewed Mar 15, 2022

View reviewed changes

xiaowei-guan added 2 commits March 15, 2022 17:59

Apply common release callback

9d37021

Merge remote-tracking branch 'upstream/flutter-2.10.1-tizen' into flu…

ed62def

…tter-2.10.1-tizen-texture

bwikbs approved these changes Mar 23, 2022

View reviewed changes

swift-kim added the no merge This PR is not ready for merge yet label Mar 24, 2022

swift-kim removed the no merge This PR is not ready for merge yet label Mar 25, 2022

swift-kim approved these changes Mar 25, 2022

View reviewed changes

swift-kim merged commit f1e1b01 into flutter-tizen:flutter-2.10.1-tizen Mar 25, 2022

This was referenced Mar 27, 2022

[webview_flutter] Apply texture API change flutter-tizen/plugins#345

Merged

[camera] Apply texture API change flutter-tizen/plugins#346

Merged

swift-kim mentioned this pull request Mar 28, 2022

Update engine hash to f6a2e2e flutter-tizen/flutter-tizen#350

Merged

bwikbs added a commit to bwikbs/engine that referenced this pull request Apr 10, 2022

Revert "Release buffer after creating egl image (flutter-tizen#259)"

d33e77d

This reverts commit f1e1b01.

bwikbs added a commit to bwikbs/engine that referenced this pull request Apr 12, 2022

Revert "Release buffer after creating egl image (flutter-tizen#259)"

414be25

This reverts commit f1e1b01.

swift-kim pushed a commit that referenced this pull request May 12, 2022

Release buffer after creating egl image (#259)

e803d7f

* Release buffer after creating egl image * No need wait for flutter engine destruct callback to destory TBM buffer. * Apply common release callback

swift-kim pushed a commit that referenced this pull request Aug 5, 2022

Release buffer after creating egl image (#259)

94cccb2

* Release buffer after creating egl image * No need wait for flutter engine destruct callback to destory TBM buffer. * Apply common release callback

swift-kim pushed a commit that referenced this pull request Sep 1, 2022

Release buffer after creating egl image (#259)

5e94934

* Release buffer after creating egl image * No need wait for flutter engine destruct callback to destory TBM buffer. * Apply common release callback

Release buffer after creating egl image #259

Release buffer after creating egl image #259

Uh oh!

Conversation

xiaowei-guan commented Mar 11, 2022

Uh oh!

swift-kim commented Mar 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xiaowei-guan commented Mar 14, 2022

Uh oh!

wb0716 left a comment

Choose a reason for hiding this comment

Uh oh!

zhouleonlei left a comment

Choose a reason for hiding this comment

Uh oh!

swift-kim left a comment

Choose a reason for hiding this comment

Uh oh!

xiaowei-guan commented Mar 15, 2022

Uh oh!

bwikbs commented Mar 15, 2022

Uh oh!

xiaowei-guan commented Mar 17, 2022

Uh oh!

xiaowei-guan commented Mar 22, 2022

Uh oh!

bwikbs commented Mar 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xiaowei-guan commented Mar 24, 2022

Uh oh!

swift-kim commented Mar 25, 2022

Uh oh!

xiaowei-guan commented Mar 25, 2022

Uh oh!

swift-kim left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

swift-kim commented Mar 14, 2022 •

edited

Loading

bwikbs commented Mar 23, 2022 •

edited

Loading