[battery_plus] Refactor the C++ code #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-kim
commented
Apr 11, 2022
Comment on lines
+61
to
+63
| return std::make_unique<FlStreamHandlerError>( | ||
| std::to_string(battery_.GetLastError()), | ||
| battery_.GetLastErrorString(), nullptr); |
Member
Author
There was a problem hiding this comment.
This currently results in an app crash. There will be a fix in the engine code soon.
Issue: flutter/flutter#101682
Member
Author
Contributor
There was a problem hiding this comment.
@swift-kim Actually, I also made a patch to prevent crash. how about this?
First one has intentional leak and the second solution you mentioned doesn't seem very good as it depends on instances of other classes.
Member
Author
There was a problem hiding this comment.
The holder_ suffix seems redundant. Otherwise looks good to me.
Contributor
There was a problem hiding this comment.
@swift-kim Can I make PR to apply all place where have same problem?
Member
Author
There was a problem hiding this comment.
Sure. Just one thing I forgot to mention: the private: section header is missing in the class.
bbrto21
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the code refactoring project.
DeviceBatteryclass fromBatteryPlusTizenPluginfor better separation of the platform channel communication and the device API usage. (I referred to the battery_plus_windows implementation.)BatteryStatusto indicate the current status of the device battery or an error status.RegisterObserver/UnregisterObserver→StartListen/StopListenStartListentakesBatteryStatusCallbackas an argument.GetLevel.GetStatus(previouslyGetBatteryStatus) return a value of typeBatteryStatus.BatteryStatusStreamHandlerclass. Now the lifecycle ofEventSinkis solely managed by this class.OnListenInternalreturns aStreamHandlerErroron initialization failure.SetupChannelsand combine withRegisterWithRegistrar.Additional note: The
batteryStategetter API has been added the platform interface and will be implemented in a later PR.