[sensors_plus] Refactor the C++ code #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
bbrto21
commented
Apr 14, 2022
Comment on lines
+32
to
+34
| return std::make_unique<FlStreamHandlerError>( | ||
| std::to_string(sensor_.GetLastError()), sensor_.GetLastErrorString(), | ||
| nullptr); |
Contributor
Author
There was a problem hiding this comment.
This currently results in an app crash. see: #351 (comment)
swift-kim
reviewed
Apr 15, 2022
Member
swift-kim
left a comment
swift-kim
left a comment
There was a problem hiding this comment.
Some minor concerns. Great job!
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Contributor
Author
|
@swift-kim I've update PR, please review again. |
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes :
DeviceSensorclassSensorsPlusPluginImplementationflutter::StreamHandlerto set stream handlersThis change contribute #354