[image_picker] Refactor the C++ code #353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the code refactoring project.
image_picker_tizen_plugin.cc
PermissionManageras a replacement forCheckPermissionAndPickContent.CheckPermissionandRequestPermssion.RequestPermssionis a blocking method.CheckPermissionmethod is not used by this package but is for use by other packages.PermissionStatusandPermissionResultrespectively.kAlloworkAllowForeverwhen compiled for TV.GetValueFromEncodableMaptemplate function to process method call arguments.SetContentMimeTypeand letPickContenttakemime_typeas an argument.SendResultWithSuccess/SendResultWithError→SendResult/SendErrorResultimage_resize.cc
Resizeand move many of its parts to individual methodsDecodeImage,TransformImage, andEncodeImageas appropriate. For example, the decode handle is created byDecodeImagebut notResize.IsValidQuality.uint32_tinstead ofunsigned int.SetSizein the definition.image_util_decode_set_colorspace.