[permission_handler] Refactor the C++ code #379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Part of the code refactoring project.
app_settings_manager.cc:AppPermissionsclass and move its logic toAppSettingsManager::OpenAppSettings. The class has been first introduced in [permission_handler] Revise OpenAppSettings #142, but adds unnecessary complexity to the code.PackageNameclass with a simple functionGetPackageName.permission_handler_tizen_plugin.cc&permission_manager.cc:PermissionManagerclass is a copy of image_picker_tizen'sPermissionManager. (See [image_picker] Refactor the C++ code #353.)PermissionStatusandPermissionResultare now a single type, in accordance with the type defined in the platform interface package.PermissionGrouptoPermission.on_successandon_errorcallbacks as everything is now done synchronously.HandleMethodCall's if-else block.kLocationresults as it's not expected by anybody.service_manager.cc:ServiceManager::CheckServiceStatussynchronous.