Skip to content

[webview_flutter] General improvements #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 26, 2022
Merged

[webview_flutter] General improvements #500

merged 2 commits into from
Dec 26, 2022

Conversation

@swift-kim
Copy link
Member

@swift-kim swift-kim commented Dec 16, 2022

  • Change the project type to staticLib.
  • Enable back key navigation.
  • Implement WebSettings.javascriptMode and WebViewController.clearCache.
  • Redirect console messages to stdout/stderr for easy debugging.
  • Minor code cleanups.

swift-kim
swift-kim commented Dec 16, 2022
View reviewed changes
packages/webview_flutter/tizen/src/webview.cc
Comment on lines 203 to +204
} else if (string_key == "allowsInlineMediaPlayback") {
// Not applicable for Tizen (always allowed).
Copy link
Member Author

@swift-kim swift-kim Dec 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true for the lightweight web engine. Is this also true for EWK?

Copy link
Contributor

@bbrto21 bbrto21 Dec 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this feature only for iOS. and as far as I know, most weview implementations are allowed inline media playback by default. so I think you don't have to care about it.

JSUYA
JSUYA reviewed Dec 19, 2022
View reviewed changes
JSUYA
JSUYA reviewed Dec 19, 2022
View reviewed changes
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't int color(in 150 line) be changed to int32_t as well?

@swift-kim
Copy link
Member Author

swift-kim commented Dec 19, 2022

@JSUYA Either way should be okay but int32_t seems to make more sense since the value is expected to be exactly 32-bits long.

bbrto21
bbrto21 approved these changes Dec 26, 2022
View reviewed changes
Copy link
Contributor

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/webview_flutter/tizen/src/webview.cc
Comment on lines 203 to +204
} else if (string_key == "allowsInlineMediaPlayback") {
// Not applicable for Tizen (always allowed).
Copy link
Contributor

@bbrto21 bbrto21 Dec 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this feature only for iOS. and as far as I know, most weview implementations are allowed inline media playback by default. so I think you don't have to care about it.

@swift-kim swift-kim merged commit bef9090 into flutter-tizen:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbrto21 bbrto21 bbrto21 approved these changes

@JSUYA JSUYA JSUYA approved these changes

Assignees

No one assigned

Labels

p: google_maps_flutter p: webview_flutter_lwe p: webview_flutter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swift-kim @bbrto21 @JSUYA