Skip to content

[webview_flutter] Use only error types known to Dart #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2023
Merged

[webview_flutter] Use only error types known to Dart #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/webview_flutter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## NEXT

* Use only error type names defined in `web_resource_error.dart`.
* Remove unused dependencies.

## 0.6.2

* Remove the use of internal API `ewk_settings_viewport_meta_tag_set`.
Expand Down
2 changes: 0 additions & 2 deletions packages/webview_flutter/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ dependencies:
path: ../

dev_dependencies:
espresso: ^0.1.0+2
flutter_driver:
sdk: flutter
flutter_test:
Expand All @@ -26,7 +25,6 @@ dev_dependencies:
sdk: flutter
integration_test_tizen:
path: ../../integration_test/
pedantic: ^1.10.0

flutter:
uses-material-design: true
Expand Down
6 changes: 5 additions & 1 deletion packages/webview_flutter/tizen/src/webview.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,16 @@ std::string ErrorCodeToString(int error_code) {
return "authentication";
case EWK_ERROR_CODE_BAD_URL:
return "badUrl";
case EWK_ERROR_CODE_CANT_CONNECT:
return "connect";
case EWK_ERROR_CODE_FAILED_TLS_HANDSHAKE:
return "failedSslHandshake";
case EWK_ERROR_CODE_FAILED_FILE_IO:
return "file";
case EWK_ERROR_CODE_CANT_LOOKUP_HOST:
return "hostLookup";
case EWK_ERROR_CODE_TOO_MANY_REDIRECTS:
return "redirectLoop";
case EWK_ERROR_CODE_REQUEST_TIMEOUT:
return "timeout";
case EWK_ERROR_CODE_TOO_MANY_REQUESTS:
Expand All @@ -78,7 +82,7 @@ std::string ErrorCodeToString(int error_code) {
return "unsupportedScheme";
default:
LOG_ERROR("Unknown error type: %d", error_code);
return std::to_string(error_code);
return "unknown";
}
}

Expand Down
7 changes: 6 additions & 1 deletion packages/webview_flutter_lwe/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
## NEXT

* Use only error type names defined in `web_resource_error.dart`.
* Remove unused dependencies.

## 0.1.0

* Initial release.
* Rename from webview_flutter_tizen to webview_flutter_lwe.
* Rename the package from webview_flutter_tizen to webview_flutter_lwe.
2 changes: 0 additions & 2 deletions packages/webview_flutter_lwe/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ dependencies:
path: ../

dev_dependencies:
espresso: ^0.1.0+2
flutter_driver:
sdk: flutter
flutter_test:
Expand All @@ -26,7 +25,6 @@ dev_dependencies:
sdk: flutter
integration_test_tizen:
path: ../../integration_test/
pedantic: ^1.10.0

flutter:
uses-material-design: true
Expand Down
2 changes: 1 addition & 1 deletion packages/webview_flutter_lwe/tizen/src/webview.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ static std::string ErrorCodeToString(int error_code) {
return "unsupportedScheme";
default:
LOG_ERROR("Unknown error type: %d", error_code);
return std::to_string(error_code);
return "unknown";
}
}

Expand Down