More analysis_options alignment #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: camera
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: messageport
p: path_provider
p: shared_preferences
p: tizen_app_control
p: tizen_app_manager
p: tizen_package_manager
p: tizen_rpc_port
p: url_launcher
p: webview_flutter
p: webview_flutter_lwe
labels
swift-kim
commented
Mar 13, 2023
swift-kim
force-pushed
the
analysis-options-230307
branch
from
33142a4 to
632cf12
Compare
swift-kim
commented
Mar 20, 2023
swift-kim
force-pushed
the
analysis-options-230307
branch
from
29f220c to
9650076
Compare
upple
approved these changes
Mar 21, 2023
Contributor
upple
left a comment
upple
left a comment
There was a problem hiding this comment.
tizen_rpc_port reviewed. 👍
Contributor
|
please, rebase master |
swift-kim
force-pushed
the
analysis-options-230307
branch
from
9650076 to
4e0e112
Compare
swift-kim
commented
Mar 22, 2023
| final dynamic position = | ||
| await _invokeChannelMethod<dynamic>('getScrollPosition'); | ||
| final Map<Object?, Object?>? position = | ||
| await _invokeChannelMethod<Map<Object?, Object?>?>('getScrollPosition'); |
Member
Author
There was a problem hiding this comment.
A better practice is to use MethodChannel.invokeMapMethod, but for now we keep using _invokeChannelMethod.
swift-kim
force-pushed
the
analysis-options-230307
branch
from
44a1b64 to
69555d2
Compare
JSUYA
reviewed
Mar 22, 2023
JSUYA
approved these changes
Mar 22, 2023
Member
JSUYA
left a comment
JSUYA
left a comment
There was a problem hiding this comment.
I checked the changes related to the webview.
swift-kim
force-pushed
the
analysis-options-230307
branch
from
e90772a to
a715b25
Compare
swift-kim
force-pushed
the
analysis-options-230307
branch
from
a715b25 to
307521b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #541. The
analysis_options.yamlin this repo will exactly match theanalysis_options.yamlin flutter/packages after this change.Related commits: