[webview_flutter_lwe] Update webview_flutter_lwe to v0.2.0 #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JSUYA
force-pushed
the
dev/webview_lwe_v4
branch
2 times, most recently
from
8ed9554 to
e0f6d79
Compare
swift-kim
reviewed
Mar 23, 2023
packages/webview_flutter_lwe/lib/src/tizen_webview_controller.dart
Outdated
Show resolved
Hide resolved
JSUYA
force-pushed
the
dev/webview_lwe_v4
branch
from
e0f6d79 to
42c275c
Compare
swift-kim
approved these changes
Mar 24, 2023
Member
swift-kim
left a comment
swift-kim
left a comment
There was a problem hiding this comment.
Looks good to me. Have you run integration tests manually?
"loadRequest with headers" - Requests with headers are not supported in LWE. "Video playback policy" - Multimedia elements are not supported in LWE. "Audio playback policy" - Multimedia elements are not supported in LWE. "target _blank opens in same window" - LWE is not supported. "clearLocalStorage" - LweWebViewController has no implementation.
Member
Author
swift-kim
reviewed
Mar 28, 2023
Comment on lines
+325
to
+329
| _onWebResourceError!(LweWebResourceError._( | ||
| errorCode: arguments['errorCode']! as int, | ||
| description: arguments['description']! as String, | ||
| failingUrl: arguments['failingUrl']! as String, | ||
| isForMainFrame: true, |
Member
There was a problem hiding this comment.
Now that the error code to type conversion is done by the Dart class, the ErrorCodeToString function and the related logic can be removed from the C++ implementation.
Member
Author
There was a problem hiding this comment.
you are right. I removed the code. and I will remove same code on webview_flutter_tizen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the changed interface from webview_flutter v4.0.2.
Related issue : #545