Skip to content

[webview_flutter] Clean up integration test and unused code #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

[webview_flutter] Clean up integration test and unused code #554

merged 1 commit into from
Apr 13, 2023

Conversation

@JSUYA
Copy link
Member

@JSUYA JSUYA commented Mar 29, 2023

  • Remove unnecessary integration test.
    • "loadRequest with headers"
      • Currently, requests with headers are not supported.
    • "Video playback policy", "Audio playback policy"
      • Doesn't work normally. (When there are multimedia elements, onPageFinished is not called from the ewk.)
    • "target _blank opens in same window"
      • Tizen ewk is not supported.
    • "clearLocalStorage"
      • TizenWebViewController has no implementation.
  • Remove unused code in webview.cc

@JSUYA JSUYA mentioned this pull request Mar 29, 2023
Closed
4 tasks
@JSUYA JSUYA force-pushed the dev/webview_flutter/fix_test branch from 53faa79 to 92ea2ad Compare March 29, 2023 05:00
@JSUYA
[webview_flutter] Clean up integration test and unused code
21a6fa4 
- Remove unnecessary integration test.
  "loadRequest with headers"
    - Currently, requests with headers are not supported.
  "Video playback policy", "Audio playback policy"
    - Doesn't work normally. (When there are multimedia elements, onPageFinished is not called from the ewk.)
  "target _blank opens in same window"
    - Tizen ewk is not supported.
  "clearLocalStorage"
    - TizenWebViewController has no implementation.
- Remove unused code in webview.cc
@JSUYA JSUYA force-pushed the dev/webview_flutter/fix_test branch from 92ea2ad to 21a6fa4 Compare March 30, 2023 05:20
@JSUYA JSUYA mentioned this pull request Mar 30, 2023
Merged
@JSUYA
Copy link
Member Author

JSUYA commented Mar 30, 2023

Version is updated in #555.

@swift-kim swift-kim merged commit fc9cb6d into flutter-tizen:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swift-kim swift-kim swift-kim approved these changes

Assignees

No one assigned

Labels

p: webview_flutter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JSUYA @swift-kim