Skip to content

Conversation

@Swanseo0
Copy link
Contributor

@Swanseo0 Swanseo0 commented Apr 5, 2023

Apply the changed interface from webview_flutter_lwe v0.2.0

@Swanseo0 Swanseo0 marked this pull request as draft April 5, 2023 08:28
@Swanseo0 Swanseo0 marked this pull request as ready for review April 6, 2023 05:28
@bbrto21
Copy link
Contributor

bbrto21 commented Apr 13, 2023

The integration test for this plugin is skipped in CI, so you must check manually.
I've run the test but I got failures, I think you should check test related things before review.

@bbrto21 bbrto21 added the verify test manually Integration tests must be verified manually. label Apr 13, 2023
@Swanseo0 Swanseo0 marked this pull request as draft April 17, 2023 05:00
@Swanseo0 Swanseo0 force-pushed the maps_update branch 2 times, most recently from c60edbf to be09a88 Compare April 28, 2023 11:28
Signed-off-by: swan.seo <swan.seo@samsung.com>
@Swanseo0 Swanseo0 marked this pull request as ready for review April 28, 2023 11:40
@Swanseo0 Swanseo0 requested review from JSUYA, bbrto21 and swift-kim April 28, 2023 11:45
@bbrto21
Copy link
Contributor

bbrto21 commented May 2, 2023

@Swanseo0 Could you please add a result of internal test you manually ran? It would be nice if you could simply leave it as a comment.

@Swanseo0 Swanseo0 closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: google_maps_flutter verify test manually Integration tests must be verified manually.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants