Skip to content

[flutter_webrtc] Support frame cryptor #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 10, 2023
Merged

[flutter_webrtc] Support frame cryptor #563

merged 8 commits into from
May 10, 2023

Conversation

@wanchao-xu
Copy link
Contributor

@wanchao-xu wanchao-xu commented Apr 26, 2023 •
edited
Loading

  1. Update flutter_webrtc to 0.9.28 version.
  2. Fix data channel does not work issue.
  3. Support frame cryptor.

@wanchao-xu wanchao-xu requested review from a team, xiaowei-guan and xuelian-bai and removed request for xiaowei-guan and xuelian-bai April 26, 2023 05:11
@swift-kim swift-kim requested a review from bbrto21 April 27, 2023 06:58
bbrto21
bbrto21 reviewed Apr 28, 2023
View reviewed changes
@swift-kim
Copy link
Member

swift-kim commented Apr 28, 2023

@bbrto21 The implementation should be kept aligned with https://github.com/flutter-webrtc/flutter-webrtc/tree/main/common/cpp as much as possible.

@wanchao-xu
Modify unsupported case of the RTCMediaType.
f838cfe 
Replace std::list to std::vector.
@bbrto21
Copy link
Contributor

bbrto21 commented May 2, 2023

Looks good to me.

@bbrto21
Copy link
Contributor

bbrto21 commented May 2, 2023

@bbrto21 The implementation should be kept aligned with https://github.com/flutter-webrtc/flutter-webrtc/tree/main/common/cpp as much as possible.

@swift-kim Oh, I see. thanks you for informed that.

@wanchao-xu
Copy link
Contributor Author

wanchao-xu commented May 9, 2023

@swift-kim , Can I merge this commit?

@wanchao-xu
Copy link
Contributor Author

wanchao-xu commented May 9, 2023

About the crash issue of video room, please refer to flutter-webrtc/flutter-webrtc#1342

@swift-kim swift-kim changed the title [flutter_webrtc] Update flutter_webrtc_tizen plugin [flutter_webrtc] Support frame cryptor May 10, 2023
@swift-kim
Copy link
Member

swift-kim commented May 10, 2023

@wanchao-xu Did you test the plugin on both TV and common?

@wanchao-xu
Copy link
Contributor Author

wanchao-xu commented May 10, 2023

@wanchao-xu Did you test the plugin on both TV and common?

This plugin only work on TV, and I tested it on TV.

@swift-kim
Copy link
Member

swift-kim commented May 10, 2023 •
edited
Loading

The README mentions "other Tizen devices" so I thought it would work on common. Is it not the case?

Also if the plugin only works on TV, we shouldn't need the arm64 binary for now.

@wanchao-xu
Copy link
Contributor Author

wanchao-xu commented May 10, 2023 •
edited
Loading

The flutter webrtc can work on RB5, and it use arm64. The other TV devices can be RB5.
And I think flutter webrtc also can work on tizen mobile, but we doesn't have tizen mobile.

@swift-kim swift-kim merged commit 14ab39a into flutter-tizen:master May 10, 2023
@swift-kim
Copy link
Member

swift-kim commented May 10, 2023

pubspec.yaml has not been updated and thus this version will not be released.

@swift-kim swift-kim mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbrto21 bbrto21 bbrto21 approved these changes

@xuelian-bai xuelian-bai Awaiting requested review from xuelian-bai

@swift-kim swift-kim Awaiting requested review from swift-kim

@xiaowei-guan xiaowei-guan Awaiting requested review from xiaowei-guan

Assignees

No one assigned

Labels

p: flutter_webrtc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wanchao-xu @swift-kim @bbrto21