-
Notifications
You must be signed in to change notification settings - Fork 52
[shared_preferences] Update to support shared_preferences 2.2.0 #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JSUYA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested the newly added API? There is no this api's unit test in shared_preferences's integration_test. (Tested on each platform implementation.)
In this case, it is better to write the results in the comment after testing.
|
However, even before clearWithParameters's failed was fixed, integration_test was still all pass. |
Yes. I think I was wrong. It seems the test of original package missed this point. For more accurate test, we need to add more test code. |
JSUYA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Swanseo0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
clearWithParametersandgetAllWithParameters