Skip to content

Conversation

@dp-IED
Copy link

@dp-IED dp-IED commented Mar 23, 2021

No description provided.

@cloudwebrtc
Copy link
Member

cloudwebrtc commented Mar 23, 2021

The http package is used here, Uri or String can be used

From code comments

  /// Sends an HTTP GET request with the given headers to the given URL, which
  /// can be a [Uri] or a [String].
  ///
  /// For more fine-grained control over the request, use [send] instead.
  Future<Response> get(url, {Map<String, String> headers});

The current version is http: ^0.12.1, if you want to merge this PR, you can change
http: version upgraded to ^0.13.1

@dp-IED
Copy link
Author

dp-IED commented Mar 23, 2021 via email

@ghenry
Copy link

ghenry commented Mar 23, 2021 via email

@dp-IED
Copy link
Author

dp-IED commented Mar 23, 2021 via email

@cloudwebrtc
Copy link
Member

@ColleSerre I think it can be merged for compatibility. I checked the older version that can support Uri, so I will merge it

@cloudwebrtc cloudwebrtc merged commit a11d797 into flutter-webrtc:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants