Skip to content

Conversation

@DeTuksa
Copy link
Contributor

@DeTuksa DeTuksa commented Nov 24, 2025

Added link attachement to popup menu

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.
Simulator Screenshot - iPhone 16 Pro - 2025-11-24 at 16 32 32 Simulator Screenshot - iPhone 16 Pro - 2025-11-24 at 16 32 37 Simulator Screenshot - iPhone 16 Pro - 2025-11-24 at 16 32 44

@csells
Copy link
Contributor

csells commented Nov 24, 2025

Love it! I think we need a different visual for the link attachment however. instead of the mime type, it should show the link itself along with a tooltip for the entire thing (do the other attachment types have tooltips? they should!). also, I think instead of the paperclip icon it should be the link icon. otherwise, this is looking solid!

@DeTuksa
Copy link
Contributor Author

DeTuksa commented Nov 24, 2025

@csells updated the visuals now for link attachments. The other attachment types already have tool tips so didn't touch on that. I implemented attempting fetching the links favicon and if not found then it falls back to the default link icon. Heres a screenshot of how it looks:
Simulator Screenshot - iPhone 16 Pro - 2025-11-25 at 00 28 51

@csells
Copy link
Contributor

csells commented Nov 25, 2025

That is above and beyond. Well done! I'll do a merge tomorrow and a release next week with some others I'm working on.

@csells csells merged commit 9ff66b0 into flutter:main Nov 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants