Skip to content

do not test on half-installed Flutter#123

Merged
yjbanov merged 2 commits intoflutter:masterfrom
yjbanov:protection-against-botched-installations
Mar 29, 2017
Merged

do not test on half-installed Flutter#123
yjbanov merged 2 commits intoflutter:masterfrom
yjbanov:protection-against-botched-installations

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Mar 29, 2017

No description provided.

@yjbanov yjbanov requested a review from goderbauer March 29, 2017 18:04
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use the path lib to concat?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@yjbanov yjbanov merged commit ec17160 into flutter:master Mar 29, 2017
ievdokdm added a commit to ievdokdm/cocoon that referenced this pull request Feb 17, 2026
Task: Implement SHA Display in PreSubmitView Header
Summary: Updated the title construction logic in PreSubmitView to include the first 7 characters of the commit SHA. The header now follows the format 'PR flutter#123 by author (sha)' when loaded, 'PR flutter#123' when loading via PR, and '(sha)' when loading via SHA.
Files: dashboard/lib/views/presubmit_view.dart, dashboard/test/views/presubmit_view_test.dart
Why: Improves visibility of the specific commit being inspected in the CI results view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments