Skip to content

Update the bot check to recognise Swift tests#5024

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
cbracken:recognise-swift-tests
Apr 17, 2026
Merged

Update the bot check to recognise Swift tests#5024
auto-submit[bot] merged 1 commit intoflutter:mainfrom
cbracken:recognise-swift-tests

Conversation

@cbracken
Copy link
Copy Markdown
Member

Files ending in Test.swift are now recognised as valid tests. Previously, we checked for extensions like .mm, .cc, .dart, etc., but did not include .swift. This change ensures that Swift files are also covered.

Fixes: flutter/flutter#185194

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • [S] I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Files ending in `Test.swift` are now recognised as valid tests.
Previously, we checked for extensions like `.mm`, `.cc`, `.dart`, etc.,
but did not include `.swift`. This change ensures that Swift files are
also covered.
@cbracken cbracken requested review from jmagman and jtmcdole April 17, 2026 07:28
@cbracken cbracken changed the title Update the engine test check to recognise Swift tests Update the bot check to recognise Swift tests Apr 17, 2026
@jtmcdole jtmcdole added the CICD Run CI/CD label Apr 17, 2026
@jtmcdole jtmcdole self-requested a review April 17, 2026 13:52
@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App. label Apr 17, 2026
@auto-submit auto-submit Bot merged commit 0ed7595 into flutter:main Apr 17, 2026
68 checks passed
@cbracken cbracken deleted the recognise-swift-tests branch April 17, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App. CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS] Recognise Swift tests as tests in the GitHub test check bot

2 participants