Overhaul CICD label management for presubmits#5028
Overhaul CICD label management for presubmits#5028auto-submit[bot] merged 3 commits intoflutter:mainfrom
Conversation
This change overhauls the state management for the `CICD` label to ensure trusted users can run CI seamlessly and external contributors require explicit approval. - PR Opened: Privileged users (non-draft) auto-trigger CI and get the label. Non-privileged or draft PRs go to awaiting state. - Changes Pushed (Synchronize): Privileged users trigger CI if label is present. Non-privileged users have the label removed and go to awaiting state. - Edits: Removed automatic label adding on base branch changes. - Consolidated usage of `_scheduleIfMergeable` to ensure consistent conflict checking and label processing. - Added flowchart documentation in `app_dart/docs/cicd_flowchart.md`.
|
Also, when looking a the |
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
LGTM, though as I mentioned offline, I think the call to githubService.isTeamMember that _isPrivilegedUser depends upon is currently not working because (I believe, based on inspecting the logs I added in #5023) the token we are using doesn't have permission to read org membership. The autosubmit label is doing this successfully, so I think we just need to look at the permissions diff and iron that out
eyebrowsoffire
added
CICD
eyebrowsoffire
added
the
revert
|
A reason for requesting a revert of flutter/cocoon/5028 could |
auto-submit
Bot
removed
the
revert
2 participants
This change overhauls the state management for the
CICDlabel to ensure trusted users can run CI seamlessly and external contributors require explicit approval._scheduleIfMergeableto ensure consistent conflict checking and label processing.app_dart/docs/cicd_flowchart.md.Once this is merged and deployed, we can remove the "remove CICD label" workflows from the other repos since that's all handled in cocoon now.