Update firebase-get-to-know-flutter
#2345
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates dependencies across multiple steps of the firebase-get-to-know-flutter codelab. The main changes involve updating go_router and provider packages in the pubspec.yaml files, and regenerating the corresponding iOS and macOS project files. The changes look good overall. I've added a few suggestions to sort the dependencies in the pubspec.yaml files alphabetically. This improves readability and aligns with the sort_pub_dependencies lint rule often used with flutter_lints, which is recommended in your style guide.
parlough
left a comment
parlough
left a comment
There was a problem hiding this comment.
Looks good to me, but one small regression and a few links that could be updated:
| network to communicate with the Firebase servers, you need to configure your app | ||
| with network client privileges. | ||
|
|
||
| #### [macos/Runner/DebugProfile.entitlements](https://github.com/flutter/codelabs/blob/master/firebase-get-to-know-flutter/step_04/macos/Runner/DebugProfile.entitlements) |
There was a problem hiding this comment.
It seems this and the other flutter/codelabs link in the doc were changed to reference master instead of main. Since the repository uses main, can you undo that change?
There was a problem hiding this comment.
Hooboy, good catch. The published codelab is still running with links to master.
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
Co-authored-by: Parker Lougheed <parlough@gmail.com>
| Theme.of(context).textTheme, | ||
| ), | ||
| visualDensity: VisualDensity.adaptivePlatformDensity, | ||
| useMaterial3: true, |
| }); | ||
| // ...to here. | ||
| } else { | ||
| _loginState = ApplicationLoginState.loggedOut; |
There was a problem hiding this comment.
This might be a reversion.
|
Landing this as is so that it matches what has just been published on codelabs.developers.google.com |
2 participants
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.