Skip to content

Conversation

@domesticmouse
Copy link
Contributor

For context, please see flutter/flutter#177296

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly disables the audio_soloud codelab from the stable CI by commenting it out in the flutter_ci_script_stable.sh script. The inclusion of a comment with a link to the tracking issue is a great practice for maintainability, as it provides clear context for the change. The modification is straightforward and effectively achieves its goal. There are no issues to report.

@domesticmouse domesticmouse changed the title Elide audio_soloud from stable CI Elide multiple codelabs from main CI Oct 21, 2025
@domesticmouse domesticmouse merged commit d83532b into main Oct 22, 2025
10 checks passed
@domesticmouse domesticmouse deleted the elide-audio-soloud branch October 22, 2025 00:15
@domesticmouse domesticmouse mentioned this pull request Oct 22, 2025
4 tasks
domesticmouse added a commit that referenced this pull request Oct 23, 2025
The `@experimental` issue with `audio_soloud` should now be fixed.

Context: #2350

## Pre-launch Checklist

- [x] I read the [Effective Dart: Style] _recently_, and have followed
its advice.
- [x] I signed the [CLA].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel
channel on [Discord].

<!-- Links -->
[Effective Dart: Style]:
https://dart.dev/guides/language/effective-dart/style
[CLA]: https://cla.developers.google.com/
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants