Skip to content

Conversation

@jwren
Copy link
Member

@jwren jwren commented Nov 17, 2025

Now consistent with the Flutter IJ repo. Related PR: flutter/flutter-intellij#8614

@jwren jwren requested review from helin24 and pq November 17, 2025 20:58
@gemini-code-assist
Copy link

Summary of Changes

Hello @jwren, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a standardized pull request template for the repository. The primary goal is to streamline the PR submission process by providing clear guidelines and a consistent structure for descriptions, ensuring that all necessary information is provided upfront. This change aims to improve the efficiency of reviews and maintain a high standard for contributions.

Highlights

  • New Pull Request Template: A new file, .github/PULL_REQUEST_TEMPLATE.md, has been added to the repository. This template will now automatically populate the description field when a new pull request is opened.
  • Standardized Contribution Guidelines: The template includes sections for contributors to describe their changes, link relevant issues, and a checklist to confirm they have reviewed the contributor guide. It also provides links to general contribution expectations, Dart style guides, and discussions on Java/Kotlin best practices.
  • Consistency with Flutter IJ Repo: This new template is consistent with the one used in the Flutter IntelliJ repository, promoting a unified contribution experience across related projects.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a pull request template, which is a great step towards standardizing contributions. The template is well-structured, but I've identified a few areas for improvement. Specifically, there's a broken markdown link that needs fixing, and a couple of minor formatting adjustments that will enhance the template's readability and correctness. My suggestions address these points to ensure the template is effective for all contributors.

<details>
<summary>Contribution guidelines:</summary><br>

- See our [contributor guide]([https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md) for general expectations for PRs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The markdown syntax for the link to the contributor guide is incorrect due to nested link syntax [text]([url](url)). This will result in a broken link in the rendered pull request description. It should be corrected to the standard [text](url) format.

Suggested change
- See our [contributor guide]([https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md) for general expectations for PRs.
- See our [contributor guide](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md) for general expectations for PRs.

@@ -0,0 +1,14 @@
- Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The introductory text is formatted as a list item due to the leading -. It would be more appropriate as a regular paragraph for better readability.

Suggested change
- Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.
Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

- [ ] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

<details>
<summary>Contribution guidelines:</summary><br>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The <br> tag after the <summary> is unnecessary and not standard practice. A blank line after the <summary> tag is sufficient to start the content of the <details> block on a new line, and is cleaner.

Suggested change
<summary>Contribution guidelines:</summary><br>
<summary>Contribution guidelines:</summary>

@jwren jwren merged commit 4eed1bf into flutter:main Nov 17, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants