-
Notifications
You must be signed in to change notification settings - Fork 2
Create the initial .github/PULL_REQUEST_TEMPLATE.md for this repo
#83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,14 @@ | ||||||
| - Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below. | ||||||
|
|
||||||
| --- | ||||||
|
|
||||||
| - [ ] I’ve reviewed the contributor guide and applied the relevant portions to this PR. | ||||||
|
|
||||||
| <details> | ||||||
| <summary>Contribution guidelines:</summary><br> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Suggested change
|
||||||
|
|
||||||
| - See our [contributor guide]([https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md](https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md) for general expectations for PRs. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The markdown syntax for the link to the contributor guide is incorrect due to nested link syntax
Suggested change
|
||||||
| - Larger or significant changes should be discussed in an issue before creating a PR. | ||||||
| - Dart contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. | ||||||
| - Java and Kotlin contributions should strive to follow Java and Kotlin best practices ([discussion](https://github.com/flutter/flutter-intellij/issues/8098)). | ||||||
| </details> | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The introductory text is formatted as a list item due to the leading
-. It would be more appropriate as a regular paragraph for better readability.