Bump dtd dep to 4.0.0 (#9240)

Author: kenzieschmoll

packages/devtools_app/lib/src/shared/editor/editor_client.dart

@@ -33,21 +33,24 @@ class EditorClient extends DisposableController
 
   Future<void> _initialize() async {
     autoDisposeStreamSubscription(
-      _dtd.onEvent('Service').listen((data) {
+      _dtd.onEvent(CoreDtdServiceConstants.servicesStreamId).listen((data) {
         final kind = data.kind;
-        if (kind != 'ServiceRegistered' && kind != 'ServiceUnregistered') {
+        if (kind != CoreDtdServiceConstants.serviceRegisteredKind &&
+            kind != CoreDtdServiceConstants.serviceUnregisteredKind) {
           return;
         }
 
-        final service = data.data['service'] as String?;
+        final service = data.data[DtdParameters.service] as String?;
         if (service == null ||
             (service != editorServiceName && service != lspServiceName)) {
           return;
         }
 
-        final isRegistered = kind == 'ServiceRegistered';
-        final method = data.data['method'] as String;
-        final capabilities = data.data['capabilities'] as Map<String, Object?>?;
+        final isRegistered =
+            kind == CoreDtdServiceConstants.serviceRegisteredKind;
+        final method = data.data[DtdParameters.method] as String;
+        final capabilities =
+            data.data[DtdParameters.capabilities] as Map<String, Object?>?;
         final lspMethod = LspMethod.fromMethodName(method);
         if (lspMethod != null) {
           lspMethod.isRegistered = isRegistered;
@@ -126,7 +129,7 @@ class EditorClient extends DisposableController
       }),
     );
     await [
-      _dtd.streamListen('Service'),
+      _dtd.streamListen(CoreDtdServiceConstants.servicesStreamId),
       _dtd.streamListen(editorStreamName).catchError((_) {
         // Because we currently call streamListen in two places (here and
         // ThemeManager) this can fail. It doesn't matter if this happens,

packages/devtools_app/pubspec.yaml

@@ -26,7 +26,7 @@ dependencies:
   devtools_app_shared:
   devtools_extensions:
   devtools_shared:
-  dtd: ^3.0.0
+  dtd: ^4.0.0
   file: ^7.0.0
   file_selector: ^1.0.0
   fixnum: ^1.1.0

packages/devtools_app/test/screens/dtd/events_test.dart

@@ -71,19 +71,19 @@ void main() {
           ConnectedAppServiceConstants.serviceName,
           ConnectedAppServiceConstants.vmServiceRegistered,
           {
-            EventParameters.uri: 'ws://127.0.0.1:30000/4G4UPw7fyoQ=/',
-            EventParameters.exposedUri: 'ws://127.0.0.1:30000/4G4UPw7fyoQ=/',
-            EventParameters.name: 'Flutter - Android (debug)',
+            DtdParameters.uri: 'ws://127.0.0.1:30000/4G4UPw7fyoQ=/',
+            DtdParameters.exposedUri: 'ws://127.0.0.1:30000/4G4UPw7fyoQ=/',
+            DtdParameters.name: 'Flutter - Android (debug)',
           },
           0,
         ),
         DTDEvent(
           ConnectedAppServiceConstants.serviceName,
           ConnectedAppServiceConstants.vmServiceUnregistered,
           {
-            EventParameters.uri: 'ws://127.0.0.1:40000/4G4UPw7fyoQ=/',
-            EventParameters.exposedUri: 'ws://127.0.0.1:56050/4G4UPw7fyoQ=/',
-            EventParameters.name: 'Flutter - iOS (debug)',
+            DtdParameters.uri: 'ws://127.0.0.1:40000/4G4UPw7fyoQ=/',
+            DtdParameters.exposedUri: 'ws://127.0.0.1:56050/4G4UPw7fyoQ=/',
+            DtdParameters.name: 'Flutter - iOS (debug)',
           },
           1,
         ),

packages/devtools_app_shared/CHANGELOG.md

@@ -4,7 +4,7 @@ Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 -->
 ## 0.4.0
-* Bump `dtd` dependency to `^3.0.0`.
+* Bump `dtd` dependency to `^4.0.0`.
 * Bump `devtools_shared` dependency to `^12.0.0`.
 * Add `DisposableController.init` method and `DisposableController.disposed`
 getter.

packages/devtools_app_shared/pubspec.yaml

@@ -16,7 +16,7 @@ dependencies:
   collection: ^1.15.0
   dds_service_extensions: ^2.0.0
   devtools_shared: ^12.0.0
-  dtd: ^3.0.0
+  dtd: ^4.0.0
   flutter:
     sdk: flutter
   logging: ^1.1.1

packages/devtools_extensions/example/packages_with_extensions/foo/packages/foo_devtools_extension/pubspec.yaml

@@ -16,7 +16,7 @@ dependencies:
     path: ../../../../../../devtools_app_shared
   devtools_extensions:
     path: ../../../../../../devtools_extensions 
-  dtd: ^3.0.0
+  dtd: ^4.0.0
   path: ^1.8.0
   flutter:
     sdk: flutter

packages/devtools_shared/CHANGELOG.md

@@ -4,7 +4,7 @@ Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 -->
 # 12.0.0
-* Update `dtd` dependency to `^3.0.0`.
+* Update `dtd` dependency to `^4.0.0`.
 * Register and unregister VM service connections on DTD. This change only
 applies to the case where the DevTools server starts DTD (i.e. when a DTD
 connection was not passed to the server on startup).

packages/devtools_shared/pubspec.yaml

@@ -16,7 +16,7 @@ resolution: workspace
 dependencies:
   args: ^2.4.2
   collection: ^1.15.0
-  dtd: ^3.0.0
+  dtd: ^4.0.0
   extension_discovery: ^2.1.0
   meta: ^1.9.1
   path: ^1.8.0

packages/devtools_test/pubspec.yaml

@@ -20,7 +20,7 @@ dependencies:
   devtools_app:
   devtools_app_shared:
   devtools_shared:
-  dtd: ^3.0.0
+  dtd: ^4.0.0
   flutter:
     sdk: flutter
   flutter_test: