Crash on flutter_web when selecting anything in widget select mode.

[Markzipan]

webdev: webdev 2.0.0-alpha.4
dart: 2.2.1

Clicking anything on the flutter_web gallery emits this error:

main.dart.js:2747 DevTools version 0.0.16.
main.dart.js:2747 Unrecognized error: type '_InternalLinkedHashMap<String, dynamic>' is not a subtype of type 'Map<String, String>' (-32603) from evaluate()
main.dart.js:19738 Uncaught TypeError: Cannot read property 'valueAsString' of undefined
    at main.dart.js:35021
    at _wrapJsFunctionForAsync_closure.$protected (main.dart.js:3480)
    at _wrapJsFunctionForAsync_closure.call$2 (main.dart.js:17696)
    at _awaitOnObject_closure.call$1 (main.dart.js:17682)
    at _RootZone.runUnary$2$2 (main.dart.js:19813)
    at _Future__propagateToListeners_handleValueCallback.call$0 (main.dart.js:18520)
    at Object._Future__propagateToListeners (main.dart.js:3680)
    at _Future._complete$1 (main.dart.js:18346)
    at _SyncCompleter.complete$1 (main.dart.js:18180)
    at Object.eval (eval at Closure_forwardInterceptedCallTo (main.dart.js:1556), <anonymous>:3:38)
main.dart.js:2747 Unrecognized error: type '_InternalLinkedHashMap<String, dynamic>' is not a subtype of type 'Map<String, String>' (-32603) from evaluate()
main.dart.js:19738 Uncaught TypeError: Cannot read property 'valueAsString' of undefined
    at main.dart.js:35021
    at _wrapJsFunctionForAsync_closure.$protected (main.dart.js:3480)
    at _wrapJsFunctionForAsync_closure.call$2 (main.dart.js:17696)
    at _awaitOnObject_closure.call$1 (main.dart.js:17682)
    at _RootZone.runUnary$2$2 (main.dart.js:19813)
    at _Future__propagateToListeners_handleValueCallback.call$0 (main.dart.js:18520)
    at Object._Future__propagateToListeners (main.dart.js:3680)
    at _Future._complete$1 (main.dart.js:18346)
    at _SyncCompleter.complete$1 (main.dart.js:18180)
    at Object.eval (eval at Closure_forwardInterceptedCallTo (main.dart.js:1556), <anonymous>:3:38)

This could just be an error on my local machine, as Nick couldn't reproduce this on his machine. I ran 'pub upgrade' as well.

[efortuna]

I am seeing this as well, and this is a blocker for our I/O talk for a certain high profile feature we very much want to show.

[efortuna]

cc @jacob314 @jakemac53 @grouma

[efortuna]

I am running:
webdev: webdev 2.0.0
dart: 2.3.0-dev.0.1 cf4444b803
(Flutter 1.5.4 • channel dev • Framework revision b593f5167b )

[devoncarew]

I think these are two separate errors:

main.dart.js:2747 Unrecognized error: type '_InternalLinkedHashMap<String, dynamic>' is not a subtype of type 'Map<String, String>' (-32603) from evaluate()

This looks like it's happening in webdev (possibly in response to an evaluate request?).

And this:

main.dart.js:19738 Uncaught TypeError: Cannot read property 'valueAsString' of undefined
    at main.dart.js:35021
    at _wrapJsFunctionForAsync_closure.$protected (main.dart.js:3480)
    at _wrapJsFunctionForAsync_closure.call$2 (main.dart.js:17696)
    at _awaitOnObject_closure.call$1 (main.dart.js:17682)
    at _RootZone.runUnary$2$2 (main.dart.js:19813)
    at _Future__propagateToListeners_handleValueCallback.call$0 (main.dart.js:18520)
    at Object._Future__propagateToListeners (main.dart.js:3680)
    at _Future._complete$1 (main.dart.js:18346)
    at _SyncCompleter.complete$1 (main.dart.js:18180)

Looks like it's from the devtools inspector code. We may need to try and repo locally, and use ddc to get good line numbers, to figure out what's happening here.

[efortuna]

cc @jmesserly Jenny was looking into this and can probably give a few more details.

[jmesserly]

Yeah the two errors seem related. The type error happens in the evaluate call, and after the error is caught on the devtools side, it calls _handleError and returns null. The null leads to the devtools stacktrace.

There's no stack trace from the evaluate call, so I'm not sure where the type error is comping from, but it seemed to be inside WidgetInspectorService. edit: at the very least, it came back as an RPCError.

[jacob314]

We're getting strange output back when we call eval. Lets sync up in the morning and figure out what fraction of eval calls are expected to work. We can disable all eval calls that won't work when we detect the app is running flutter_web.

[devoncarew]

I found one or two initial issues, but still see:

Uncaught, null, 771, 18, object null
#0      WipRuntime.evaluate (package:webkit_inspection_protocol/src/runtime.dart:23:7)
<asynchronous suspension>
#1      ChromeProxyService.evaluate (package:dwds/src/chrome_proxy_service.dart:254:46)
<asynchronous suspension>
#2      VmServerConnection._delegateRequest (package:vm_service_lib/vm_service_lib.dart:749:51)
<asynchronous suspension>

so I suspect there's more to do here in terms of getting things plumbed end to end.

[jakemac53]

'_InternalLinkedHashMap<String, dynamic>' is not a subtype of type 'Map<String, String>' This actually sounds like it could be the result of calling a bad service extension? Service extensions have to return a Map<String, String> but they aren't written in a way that gives good static errors if I recall.

[devoncarew]

That should be addressed by the package:vm_service_lib fix above. The fix has been published as 3.15.1+1 but needs to be rolled into webdev.