Skip to content

Improve experience in Internet Explorer + tweak Edge message #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Improve experience in Internet Explorer + tweak Edge message #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d62ab99
Redirect browsers that don't support ES6 classes to an unsupported page
DanTup Apr 16, 2019
6e79829
Change name for IE since it includes Edge too
DanTup Apr 16, 2019
fee2b52
Fix typo
DanTup Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/devtools/web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,17 @@
<link rel="stylesheet" href="packages/devtools/src/timeline/timeline.css">

<script type="text/javascript">
function supportsES6Classes() {
"use strict";
try { eval("class Foo {}"); }
catch (e) { return false; }
return true;
}

if (!supportsES6Classes()) {
window.location.href = '/unsupported-browser.html';
}

(function() {
var params = new URLSearchParams(window.location.search);
if (params.get('theme') == 'dark') {
Expand Down
8 changes: 6 additions & 2 deletions packages/devtools/web/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,13 @@ void main() {
final PerfToolFramework framework = PerfToolFramework();

if (!browser.isChrome) {
final browserName =
// Edge shows up as IE, so we replace it's name to avoid confusion.
browser.isInternetExplorer || browser == Browser.UnknownBrowser
? 'an unsupported browser'
: browser.name;
framework.disableAppWithError(
'ERROR: You are running DevTools on '
'${browser.name == Browser.UnknownBrowser.name ? 'an unknown browswer' : browser.name}, '
'ERROR: You are running DevTools on $browserName, '
'but DevTools only runs on Chrome.',
'Reopen this url in a Chrome browser to use DevTools.',
);
Expand Down
16 changes: 16 additions & 0 deletions packages/devtools/web/unsupported-browser.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<!DOCTYPE html>
<html>
<head>
<title>Dart DevTools - Unsupported Browser</title>
<style>
body {
margin: 50px 30px;
font-family: "Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol";
}
</style>
</head>
<body>
<h1>Unsupported Browser</h1>
<p>Your browser is not supported by DevTools. Please try using Google Chrome.</p>
</body>
</html>