Fix CPU Profiler with "advanced developer mode" is enabled #9528
+160
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
requested review from
a team,
bkonyi and
kenzieschmoll
as code owners
elliette
requested review from
jakemac53
and removed request for
bkonyi and
kenzieschmoll
elliette
commented
Nov 21, 2025
| } | ||
| } else { | ||
| final functions = samples.functions; | ||
| if (functions == null || index >= functions.length) return null; |
Member
Author
There was a problem hiding this comment.
This check index >= functions.length is not strictly necessary but I want to be extra safe.
elliette
commented
Nov 21, 2025
| "tid": 100, | ||
| "timestamp": 50, | ||
| "stack": [0, 1], | ||
| "_codeStack": [2] |
Member
Author
There was a problem hiding this comment.
Before the change, the regression test would fail because we would try to index into functions[2] which only has 2 items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9526
Fixes bug in implementation of
getResolvedUrlwhich was throwing an index out of range error when advanced developer mode was enabled.When advanced developer mode is enabled, the CPU profile also includes the code tree. Therefore, in the original ternary,
isCodeTreeis true. The issue happened when_function is vm_service.FuncRef?was false. Then we would fall back to the false case in the ternary. We would then try to index into the profile's functions list with an index that was actually intended for the code objects list.