This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Always keep thread merged when there are platform views. #18245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
requested review from
iskakaushik and
blasten
and removed request for
gw280
blasten
reviewed
May 8, 2020
| // Returns true if there are embedded in the scene at current frame | ||
| // Or there will be embedded in the next frame. | ||
| // TODO(cyanglaz): https://github.com/flutter/flutter/issues/56474 | ||
| // Remove this method is the issue above is resloved. |
There was a problem hiding this comment.
Remove this method when the issue above is resolved?.
added 2 commits
May 8, 2020 16:34
|
The |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2020
iskakaushik
pushed a commit
to flutter/flutter
that referenced
this pull request
May 14, 2020
* 7b64067 Use 'message' as the parameter name in FlMessageCodec::encode_message (flutter/engine#18253) * 429beae Roll src/third_party/skia 3d2c41b773f6..3ebadcc98eab (14 commits) (flutter/engine#18333) * 66ba3a7 Roll src/third_party/dart 2bf325900586..d6fed1f62444 (1 commits) (flutter/engine#18334) * 2f8495a Completely disable paving the device on Fuchsia (flutter/engine#18340) * 006dbfc Always keep thread merged when there are platform views. (flutter/engine#18245) * 21b4d2f [web] Fix paragraph positioning (flutter/engine#18329) * efdc099 Re-enable Fuchsia tests (flutter/engine#18342) * ae2222f Revert "Re-enable Fuchsia tests (#18342)" (flutter/engine#18345)
|
(combing through recent untested PRs) |
|
AFAIK, we don't have a way to unit test this with current infra setup. (Maybe my knowledge is outdated) As far as integration tests, we probably can't test this behavior specifically. I will make sure to add an e2e test for the whole thread merging process before actually enabling the thread merging. |
wandyers
pushed a commit
to wandyers/engine
that referenced
this pull request
May 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unobstructed platform view has been implemented. So there is a chance the overlay UIView can change even there is no changes in the platform view itself. Operations in overlay also needs to be run on the platform thread.
Because the current implementation depends on the "paint" traversal to know if an overlay is going to change; and we need to merge the thread before the "paint" traversal. There is no clean way to un-merged the threads when there are platform views.
This PR keeps the threads merged until the platform views are move out of the scene completely.
issue:
flutter/flutter#56474