This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Fix paragraph positioning #18329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
May 13, 2020
| @@ -714,6 +714,10 @@ class BitmapCanvas extends EngineCanvas { | |||
| rootElement.append(paragraphElement); | |||
| } | |||
| _children.add(paragraphElement); | |||
| // If there is a prior sibling such as img prevent left/top shift. | |||
There was a problem hiding this comment.
Is there any information about why this is happening? Would be useful to leave a link explaining what causes the shift.
There was a problem hiding this comment.
No info or chromium bug i could point to. Although position is absolute and the paragraph has transform on it, it is shifting the text vertically down.
Example:
|
Merging on infra fail / mac android. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2020
iskakaushik
pushed a commit
to flutter/flutter
that referenced
this pull request
May 14, 2020
* 7b64067 Use 'message' as the parameter name in FlMessageCodec::encode_message (flutter/engine#18253) * 429beae Roll src/third_party/skia 3d2c41b773f6..3ebadcc98eab (14 commits) (flutter/engine#18333) * 66ba3a7 Roll src/third_party/dart 2bf325900586..d6fed1f62444 (1 commits) (flutter/engine#18334) * 2f8495a Completely disable paving the device on Fuchsia (flutter/engine#18340) * 006dbfc Always keep thread merged when there are platform views. (flutter/engine#18245) * 21b4d2f [web] Fix paragraph positioning (flutter/engine#18329) * efdc099 Re-enable Fuchsia tests (flutter/engine#18342) * ae2222f Revert "Re-enable Fuchsia tests (#18342)" (flutter/engine#18345)
wandyers
pushed a commit
to wandyers/engine
that referenced
this pull request
May 23, 2020
* Fix text positioning * Update golden locks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When blendmode filters are applied to elements preceding paragraphs, the paragraph elements shift unless left,top css attributes are set to 0px.
Fixes: flutter/flutter#56971
Added regression test.