This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Re-enable Fuchsia tests #18342
Merged
Re-enable Fuchsia tests #18342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godofredoc
reviewed
May 13, 2020
| exit 0 | ||
| # This is longer than the test timeout as dumping the | ||
| # logs can sometimes take longer. | ||
| ssh_timeout_seconds=360 |
There was a problem hiding this comment.
Seems like in some cases the timeouts are happening after 2 mins. That may be a default timeout inside fuchsia_ctl we may need to take a look.
There was a problem hiding this comment.
Seems like you are already covering it with the logs collection timeout.
There was a problem hiding this comment.
On glancing at the Fuchsia CTL code, the timeout passed here as an arg should override any default timeouts set. I kicked off a couple of runs to make sure that this does fix the issue. I'll keep an eye out for any potential failures.
iskakaushik
force-pushed
the
re-enable-fuchsia-engine-tests
branch
2 times, most recently
from
9b67074 to
781a77b
Compare
|
here is the LUCI run: https://ci.chromium.org/swarming/task/4c278c3f83514a10?server=chromium-swarm.appspot.com |
godofredoc
reviewed
May 13, 2020
testing/fuchsia/run_tests.sh
Outdated
| --identity-file $pkey | ||
|
|
||
| echo "$(date) START:REBOOT ------------------------------------------" | ||
| # note: this will set an exit code of 255, which we can ignore. | ||
| ./fuchsia_ctl -d $device_name ssh -c "dm reboot-recovery" \ | ||
| --timeout-seconds $ssh_timeout_seconds \ |
There was a problem hiding this comment.
We may want to use the default here, this operation should complete within milliseconds.
testing/fuchsia/run_tests.sh
Outdated
| @@ -61,6 +64,7 @@ echo "$(date) START:WAIT_DEVICE_READY -------------------------------" | |||
| for i in {1..10}; do | |||
| ./fuchsia_ctl -d $device_name ssh \ | |||
| --identity-file $pkey \ | |||
| --timeout-seconds $ssh_timeout_seconds \ | |||
There was a problem hiding this comment.
Same here the operation should complete in ms, with a faulty device this will block for 60mins
iskakaushik
force-pushed
the
re-enable-fuchsia-engine-tests
branch
from
781a77b to
9f76f96
Compare
godofredoc
approved these changes
May 13, 2020
iskakaushik
pushed a commit
to iskakaushik/engine
that referenced
this pull request
May 13, 2020
This reverts commit efdc099.
iskakaushik
added a commit
that referenced
this pull request
May 13, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 13, 2020
iskakaushik
pushed a commit
to flutter/flutter
that referenced
this pull request
May 14, 2020
* 7b64067 Use 'message' as the parameter name in FlMessageCodec::encode_message (flutter/engine#18253) * 429beae Roll src/third_party/skia 3d2c41b773f6..3ebadcc98eab (14 commits) (flutter/engine#18333) * 66ba3a7 Roll src/third_party/dart 2bf325900586..d6fed1f62444 (1 commits) (flutter/engine#18334) * 2f8495a Completely disable paving the device on Fuchsia (flutter/engine#18340) * 006dbfc Always keep thread merged when there are platform views. (flutter/engine#18245) * 21b4d2f [web] Fix paragraph positioning (flutter/engine#18329) * efdc099 Re-enable Fuchsia tests (flutter/engine#18342) * ae2222f Revert "Re-enable Fuchsia tests (#18342)" (flutter/engine#18345)
godofredoc
added a commit
that referenced
this pull request
May 14, 2020
wandyers
pushed a commit
to wandyers/engine
that referenced
this pull request
May 23, 2020
Co-authored-by: Kaushik Iska <kaushikiska@google.com>
wandyers
pushed a commit
to wandyers/engine
that referenced
this pull request
May 23, 2020
This reverts commit efdc099.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per my analysis here, most of the failures seem to be test timeouts. I'm attempting to enable the tests again.