Add a license file for impellerc, rename font-subset license #33859
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
tools/licenses/lib/main.dart
Outdated
| && entry.name != 'ocmock' // only used for tests | ||
| && entry.name != 'java' // only used for Android builds | ||
| && entry.name != 'inja' // only used on hosts for builds | ||
| && entry.name != 'inja' // Only used by impellerc, which ships a separate license |
There was a problem hiding this comment.
might be good to leave a comment there pointing to where the licenses are generated (the BUILD file above)
|
test-exempt: configuration change |
|
that said, it might eventually be worth adding a test that verifies that every binary in that archive has a corresponding license file |
Zach and I were discussing that, I think that's probably doable but it mighjt be easiest to wait until the recipes all do binaries from the GN rules rather than trying to implement it in several different places and have those get changed out |
dnfield
added
the
waiting for tree to go green
dnfield
removed
the
waiting for tree to go green
dnfield
added
the
waiting for tree to go green
4 participants
The rename is to disambiguate files that end up in the same zip archive
A separate recipe change will be needed once this lands to have the recipe pick up the new license file and vend it to the tool.
I've updated the license script comments to clarify these dependency exclusions.
If we ever ship SwiftShader as part of flutter_tester, there will be more of these to deal with, but AFAICT these are the only ones that are part of impellerc.