This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Turn on the skia_enable_optimize_size flag to save a bit of binary size"
#45082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2023
…e a bit of binary size" (flutter/engine#45082)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2023
…e a bit of binary size" (flutter/engine#45082)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2023
…e a bit of binary size" (flutter/engine#45082)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 25, 2023
…133296) flutter/engine@965501a...b8ec4da 2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 99a76ea8e1b2 to 1428f16fc0de (1 revision) (flutter/engine#45086) 2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 25fafff5b32c to 99a76ea8e1b2 (2 revisions) (flutter/engine#45083) 2023-08-24 jacksongardner@google.com Revert "Turn on the `skia_enable_optimize_size` flag to save a bit of binary size" (flutter/engine#45082) 2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from d7d56885a49b to 25fafff5b32c (1 revision) (flutter/engine#45081) 2023-08-24 dnfield@google.com [Impeller] Do not build scene unless 3d define is true (flutter/engine#45028) 2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 177e8477faf9 to d7d56885a49b (1 revision) (flutter/engine#45078) 2023-08-24 dkwingsmt@users.noreply.github.com Reland: [Rasterizer] Make resubmit information temporary (flutter/engine#45037) 2023-08-24 34871572+gmackall@users.noreply.github.com Add case checking to android sdk cipd upload script (flutter/engine#45063) 2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from 007386294889 to 177e8477faf9 (1 revision) (flutter/engine#45076) 2023-08-24 jacksongardner@google.com Turn on the `skia_enable_optimize_size` flag to save a bit of binary size (flutter/engine#45029) 2023-08-24 skia-flutter-autoroll@skia.org Roll Skia from b17ee34f3378 to 007386294889 (1 revision) (flutter/engine#45075) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
… binary size" (flutter#45082) Reverts flutter#45029 It appears this is causing a regression in the length of time some of our integration tests are taking, causing them to take twice as long, which is causing timeouts in CI. We should revert while we investigate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #45029
It appears this is causing a regression in the length of time some of our integration tests are taking, causing them to take twice as long, which is causing timeouts in CI. We should revert while we investigate.