This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add a note about Graphite to the FAQ. #54623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Action item from go/impeller-faq-followups.
chinmaygarde
added
the
autosubmit
zanderso
reviewed
Aug 19, 2024
impeller/docs/faq.md
Outdated
Comment on lines
288
to
291
| Improvements are being made in Graphite to allow for easier pre-compilation of | ||
| shaders at startup time. But, since it is still aims to support Skia’s general | ||
| 2D API and has the same spec. requirements, the inherent issues that make full | ||
| offline shader compilation possible still exist. |
There was a problem hiding this comment.
This needs some wordsmithing. E.g. around "But, since it is still aims ..."
There was a problem hiding this comment.
You're right. That sentence was a mess. I reworded it. Another look?
zanderso
removed
the
autosubmit
sethladd
reviewed
Aug 19, 2024
impeller/docs/faq.md
Outdated
| (e.g Metal, Vulkan, Dawn). It aims to reduce the CPU cost of recording commands | ||
| while taking advantage of newer GPU features. | ||
|
|
||
| Improvements are being made in Graphite to allow for easier pre-compilation of |
There was a problem hiding this comment.
this paragraph would get out of date, right?
Perhaps a phrasing here is "One of the goals of Graphite is to allow for easier pre-compilation of shaders at startup time." ? WDYT?
zanderso
approved these changes
Aug 19, 2024
sethladd
reviewed
Aug 19, 2024
impeller/docs/faq.md
Outdated
| same spec. requirements. The design decisions made to support those requirements | ||
| make offline shader compilation impossible. | ||
|
|
||
| Right now, Flutter has no plans to use Graphite. However, we, the Flutter team, |
There was a problem hiding this comment.
"As of August 2024, Flutter has ..."
|
LGTM with small tweak. Thank you! |
sethladd
approved these changes
Aug 19, 2024
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 19, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 19, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 20, 2024
…153733) flutter/engine@9d7e3a6...7dd71ff 2024-08-19 kevmoo@users.noreply.github.com web_ui: bump min Dart SDK to 3.6.0-0 (flutter/engine#54626) 2024-08-19 chinmaygarde@google.com [Impeller] Add a note about Graphite to the FAQ. (flutter/engine#54623) 2024-08-19 jacksongardner@google.com [skwasm] Fix skwasm clip coverage algorithm. (flutter/engine#54572) 2024-08-19 skia-flutter-autoroll@skia.org Roll Skia from 318b7958f748 to b6224c9e6611 (2 revisions) (flutter/engine#54625) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153733) flutter/engine@9d7e3a6...7dd71ff 2024-08-19 kevmoo@users.noreply.github.com web_ui: bump min Dart SDK to 3.6.0-0 (flutter/engine#54626) 2024-08-19 chinmaygarde@google.com [Impeller] Add a note about Graphite to the FAQ. (flutter/engine#54623) 2024-08-19 jacksongardner@google.com [skwasm] Fix skwasm clip coverage algorithm. (flutter/engine#54572) 2024-08-19 skia-flutter-autoroll@skia.org Roll Skia from 318b7958f748 to b6224c9e6611 (2 revisions) (flutter/engine#54625) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action item from go/impeller-faq-followups.