Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[CP][Android] Disable SurfaceControl based swapchains. #57173

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[CP][Android] Disable SurfaceControl based swapchains. #57173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions impeller/renderer/backend/vulkan/swapchain/swapchain_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,32 +56,6 @@ std::shared_ptr<SwapchainVK> SwapchainVK::Create(
return nullptr;
}

// TODO(147533): AHB swapchains on emulators are not functional.
auto& context_vk = ContextVK::Cast(*context);
const auto emulator = context_vk.GetDriverInfo()->IsEmulator();
const auto should_disable_sc =
context_vk.GetShouldDisableSurfaceControlSwapchain();

// Try AHB swapchains first.
if (!emulator && AHBSwapchainVK::IsAvailableOnPlatform() &&
!android::ShadowRealm::ShouldDisableAHB() && !should_disable_sc) {
auto ahb_swapchain = std::shared_ptr<AHBSwapchainVK>(new AHBSwapchainVK(
context, //
window.GetHandle(), //
surface, //
window.GetSize(), //
enable_msaa //
));

if (ahb_swapchain->IsValid()) {
return ahb_swapchain;
} else {
VALIDATION_LOG
<< "Could not create AHB swapchain. Falling back to KHR variant.";
}
}

// Fallback to KHR swapchains if AHB swapchains aren't available.
return Create(context, std::move(surface), window.GetSize(), enable_msaa);
}
#endif // FML_OS_ANDROID
Expand Down
Loading