Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Dec 16, 2024

Relands #54961 with a few more changes and tests.

Fixes flutter/flutter#160127

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Dec 16, 2024
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yjbanov
Copy link
Contributor

yjbanov commented Dec 16, 2024

Let's hotfix this in stable.

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 17, 2024
@auto-submit auto-submit bot merged commit 6a75cb6 into flutter:main Dec 17, 2024
31 checks passed
@mdebbar mdebbar added the cp: stable cherry pick to the stable release candidate branch label Dec 17, 2024
@flutteractionsbot
Copy link

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 17, 2024
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 17, 2024
…160450)

flutter/engine@8535ce3...6a75cb6

2024-12-17 mdebbar@google.com [web] Reland: (Add `crossOrigin` property
to `<img>` tag used for decoding)++ (flutter/engine#57228)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,zra@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
@Reprevise
Copy link

Has the cherry-pick request been created yet?

@putnokiabel
Copy link

@Reprevise I submitted #160819 but I haven't received a reaction on it yet and not sure I did it correctly (as it's the first time I submit a CP request).

@Reprevise
Copy link

Maybe @yjbanov can take a look?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App cp: stable cherry pick to the stable release candidate branch platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTML images from cached_network_image no longer load in 3.27

5 participants