Feature Request : Block reload/run if the error is detected by dart analyzer

[git-elliot]

Sometime when writing code I certainly make mistakes and hot reload causes my current instance to be buggy and so I lost the session. This could be better if the hot reload/restart must specify the command or changes to be triggered if required in order to run hot reload/restart more efficiently without bugs.

[jwren]

Assigning to Devon who has worked on the hot-reload dev cycle in the Flutter plugin.

[devoncarew]

@parasthekoder, we shouldn't reload code if the project has analysis errors. Are you seeing this occurring? Could you detail the repro steps for what you're seeing a bit more?

[git-elliot]

Steps to reproduce

1. Suppose I've line of code shown below

DateTime _lastDate = new DateTime.now();
String _selectedDatum;

2. And from the first line I've removed the semicolon. The dart analyzer issues that semicolon is missing.
3. Now Press Hot Reload.
4. The Run tab shows this.

Initializing hot reload...
compiler message: lib/panels/sale_purchase_panel.dart:35:3: Error: Expected ';' before this.
compiler message:   String _selectedDatum;
compiler message:   ^^^^^^
Reloaded 4 of 699 libraries in 3,660ms.

So, tell me what's the last line indicates ? Well I think it is hot reloaded but in actual it shouldn't be.

[git-elliot]

Eventually doing this repeatedly results into this fatal crash flutter/flutter#19517