Remove the bazel test runner option #3371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Apr 15, 2019
| } | ||
| }); | ||
| // Only enable scope changes if the new bazel test runner is enabled. | ||
| // If the new runner is disabled, all scopes will be blaze target-level. |
|
ping re: landing this |
|
I started a thread on the g3 users announcement list for this. Policy is to allow 1 week for discussion before landing the potentially breaking change. |
|
We are starting the next build. If we want this is this month's release, we'll need to land this. |
|
No objections internally, landing it. |
alexander-doroshko
pushed a commit
to alexander-doroshko/flutter-intellij
that referenced
this pull request
Jan 24, 2020
* Remove the bazel test runner option * Respond to Devon's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove it and clear out code paths that involve the user preference.