Make the Bazel-specific tests work again

[DaveShuckerow]

Removing the setting to enable/disable the new bazel test runner (#3371) regressed these tests.

They may have been turned off on Travis, or some other thing happened that led to not seeing them fail.

[DaveShuckerow]

After this change, I'm down to only 2 failures, both from EventStreamTest.

This is what I get:

$ ./gradlew test

> Task :test

  io.flutter.bazel.WorkspaceCacheTest

    ✔ shouldDetectConfigFileChanges (2.4s)
    ✔ shouldDetectModuleRootChange

  io.flutter.utils.EventStreamTest

    ✔ unsubscribeFromUiThread
    ✔ valueSetBeforeStart
    ✘ nullInitialValue (1s)

      java.lang.AssertionError: logEntries entries are different
      Expected: is <[null, 100, 200]>
           but: was <[null, 200]>
          at io.flutter.utils.EventStreamTest.checkLog(EventStreamTest.java:263)

    ✔ eventsFromOtherThreadOnUiThread
    ✔ calledWithDefaultValue
    ✔ eventsFromOtherThread
    ✘ duplicateValues (1s)

      java.lang.AssertionError: logEntries entries are different
      Expected: is <[42, 100, 100, 100, 200, 200]>
           but: was <[42, 200]>
          at io.flutter.utils.EventStreamTest.checkLog(EventStreamTest.java:263)

    ✔ ignoreValuesAfterDispose
    ✔ doubleDispose

  io.flutter.run.bazelTest.LaunchCommandsTest

    ✔ producesCorrectCommandLineForTestName
    ✔ producesCorrectCommandLineForBazelTarget
    ✔ failsForFileWithoutTestScript
    ✔ producesCorrectCommandLineForBazelTargetWithoutTestScriptInDebugMode
    ✔ producesCorrectCommandLineForTestNameInDebugMode
    ✔ producesCorrectCommandLineForBazelTargetWithoutTestScript
    ✔ failsForTestNameAndBazelTargetWithoutTestScript
    ✔ producesCorrectCommandLineForFileInDebugMode
    ✔ producesCorrectCommandLineForFile
    ✔ failsForTestNameWithoutTestScript
    ✔ runsInFileModeWhenBothFileAndBazelTargetAreProvided
    ✔ producesCorrectCommandLineForBazelTargetInDebugMode

  io.flutter.bazel.WorkspaceTest

    ✔ canLoadWorkspaceWithConfigFileAndScriptInReadonly
    ✔ canLoadWorkspaceWithConfigFile
    ✔ canLoadWorkspaceWithoutConfigFile

  io.flutter.bazel.PluginConfigTest

    ✔ shouldReturnNullForSyntaxError

  io.flutter.logging.FlutterLogTest

    ✔ testLevelForValue

  io.flutter.logging.text.LineParserTest

    ✔ testLinks
    ✔ testParse
    ✔ testLinkTag
    ✔ test8bitFontStyle
    ✔ test8bitBasic

  io.flutter.dart.DartSyntaxTest

    ✔ isTestCall
    ✔ shouldNotFindEnclosingFunctionCallPattern
    ✔ shouldGetFirstArgumentFromFunctionCall
    ✔ isTestCallPattern
    ✔ shouldFindEnclosingFunctionCallPattern
    ✔ shouldFindEnclosingFunctionCall
    ✔ shouldUnquoteStringLiteral
    ✔ isMainFunctionDeclaration

  io.flutter.sdk.FlutterSdkUtilsTest

    ✔ parseFlutterSdkPath

  io.flutter.sdk.FlutterSdkVersionTest

    ✔ handlesBadVersion
    ✔ trackWidgetCreationRecommendedRange
    ✔ parsesGoodVersion

  io.flutter.sdk.FlutterCreateAdditionalSettingsTest

    ✔ includeDriverPropertyTest
    ✔ iosPropertyTest
    ✔ generatePluginPropertyTest
    ✔ descriptionPropertyTest
    ✔ kotlinPropertyTest
    ✔ testMultipleProperties
    ✔ orgPropertyTest

  io.flutter.FlutterUtilsTest

    ✔ validPackageNames
    ✔ validIdentifier

  io.flutter.utils.FileWatchTest

    ✔ shouldFireEvents

  io.flutter.utils.StdoutJsonParserTest

    ✔ deepNestedJson
    ✔ simple
    ✔ unterminatedJson
    ✔ appendsWithoutLineBreaks
    ✔ splitJson
    ✔ outputConcatenatedJson

  io.flutter.utils.AsyncRateLimiterTest

    ✔ rateLimitedSlowNetwork (2s)
    ✔ rateLimited

  io.flutter.utils.ThreadUtilTest

    ✔ simple

  io.flutter.utils.RefreshableTest

    ✔ shouldNotPublishWhenClosedBeforePublish
    ✔ shouldNotPublishWhenClosedDuringRefreshCallback
    ✔ refreshShouldProvideAndUnpublishPreviousValue
    ✔ refreshShouldRecoverIfSubscriberThrows
    ✔ valueShouldBeNullAtStart
    ✔ refreshShouldNotPublishWhenCallbackThrowsException
    ✔ refreshShouldNotPublishOrUnpublishDuplicateValue
    ✔ refreshShouldYieldToQueuedEvents
    ✔ publishShouldYieldToQueuedEvents
    ✔ refreshShouldCancelRunningTaskWhenNewTaskIsSubmitted
    ✔ refreshShouldPublishNewValue

  io.flutter.utils.FlutterModuleUtilsTest

    ✔ isDeprecatedFlutterModuleType_false_JAVA_MODULE
    ✔ isDeprecatedFlutterModuleType_true (1s)
    ✔ isFlutterModule_null
    ✔ isFlutterModule_emptyModule
    ✔ isDeprecatedFlutterModuleType_false_empty_module

  io.flutter.utils.animation.CurvesTest

    ✔ ellasticOvershootsItsBounds
    ✔ bounceStaysInBounds
    ✔ curveFlippedControl
    ✔ tresholdHasAThreshold
    ✔ decelerateDoesSo

  io.flutter.samples.FlutterSampleTest

    ✔ testScaffoldDescription
    ✔ testParseShortHtmlDescription
    ✔ testParseCardDescription
    ✔ testParseHtmlDescription
    ✔ testParseDocLink
    ✔ testParseEscapes

  io.flutter.run.bazel.LaunchCommandsTest

    ✔ producesCorrectCommandLineWithBazelArgs
    ✔ producesCorrectCommandLineWithIosDevice
    ✔ producesCorrectCommandLineWithBazelAndAdditionalArgs
    ✔ producesCorrectCommandLineInProfileMode
    ✔ overridesRunModeFromBazelArgs
    ✔ producesCorrectCommandLineInReleaseMode
    ✔ producesCorrectCommandLineWithIosSimulator
    ✔ producesCorrectCommandLineInDebugMode
    ✔ producesCorrectCommandLineWithAndroidDevice
    ✔ producesCorrectCommandLineWithAndroidEmulator
    ✔ producesCorrectCommandLineInRunMode
    ✔ producesCorrectCommandLineWithAdditionalArgs

  io.flutter.run.bazel.BazelFieldsTest

    ✔ shouldUpgradeFieldsFromOldXml
    ✔ shouldReadFieldsFromXml
    ✔ roundTripShouldPreserveFields

  io.flutter.run.MainFileTest

    ✔ shouldDetectErrors
    ✔ shouldFindAppDirForValidFlutterApp

  io.flutter.run.common.TestTypeTest

    ✔ shouldNotMatchTestingWidgets
    ✔ shouldMatchTestFooBarWidgets0
    ✔ shouldMatchGroup
    ✔ shouldMatchTest0
    ✔ shouldMatchTest1
    ✔ shouldMatchTestWidgets0

  io.flutter.run.test.TestFieldsTest

    ✔ shouldReadNameScopeFieldsFromXml
    ✔ shouldReadFileScopeFieldsFromXml
    ✔ roundTripShouldPreserveNameScopeSettings
    ✔ roundTripShouldPreserveFileScopeSettings
    ✔ roundTripShouldPreserveDirectoryScopeSettings
    ✔ shouldReadDirectoryScopeFieldsFromXml

  io.flutter.run.test.TestConfigUtilsTest

    ✔ mainTestCall_negative
    ✔ mainTestCall

  io.flutter.run.bazelTest.BazelTestFieldsTest

    ✔ shouldUpgradeFieldsFromOldXml
    ✔ shouldReadFieldsFromXml
    ✔ roundTripShouldPreserveFields

  io.flutter.run.bazelTest.BazelTestConfigProducerTest

    ✔ producesFileConfigurationInsideABazelWorkspace
    ✔ producesNoConfigurationWithAnInvalidTestFile
    ✔ producesNoConfigurationOutsideABazelWorkspace
    ✔ producesTestNameConfigurationInsideABazelWorkspace

  io.flutter.run.daemon.DaemonApiTest

    ✔ canEnableDeviceEvents
    ✔ parseAndValidateDaemonEventGood
    ✔ daemonGetSupportedPlatforms
    ✔ parseAndValidateDaemonEventBad
    ✔ canCallServiceExtension
    ✔ canRestartApp
    ✔ canStopApp

  io.flutter.run.daemon.DaemonEventTest

    ✔ canReceiveAppStoppedWithError
    ✔ canReceiveProgressFinished
    ✔ canReceiveAppLog
    ✔ canReceiveShowMessage
    ✔ canReceiveAppStarting
    ✔ canReceiveLogMessage
    ✔ canReceiveAppStarted
    ✔ canReceiveAppStopped
    ✔ canReceiveDeviceAdded
    ✔ canReceiveProgressStarting
    ✔ shouldIgnoreUnknownEvent
    ✔ canReceiveDebugPort
    ✔ canReceiveDeviceRemoved

  io.flutter.run.SdkFieldsTest

    ✔ shouldReadFieldsFromOldXml
    ✔ shouldReadFieldsFromXml
    ✔ roundTripShouldPreserveFields

  io.flutter.run.PositionMapperTest

    ✔ shouldGetPositionInFileUnderRemoteBaseUri
    ✔ shouldGetPositionInFileUnderRemoteSourceRoot

  io.flutter.editor.FlutterEditorAnnotatorTest

    ✔ locatesConstColorArray
    ✔ locatesColorCtor
    ✔ locatesConstColorWhitespace
    ✔ locatesConstColorCtor
    ✔ locatesColorReference
    ✔ locatesConstIconCtor
    ✔ locatesIconCtor
    ✔ locatesIconReference

  io.flutter.project.ProjectWatchTest

    ✔ shouldSendEventWhenModuleRootsChange
    ✔ shouldSendEventWhenProjectCloses

  io.flutter.analytics.AnalyticsTest

    ✔ testSendException
    ✔ testSendTiming
    ✔ testSendScreenView
    ✔ testSendEvent
    ✔ testOptOutDoesntSend

  io.flutter.analytics.ThrottlingBucketTest

    ✔ testRemoveDrop

  io.flutter.inspector.TreeScrollAnimatorTest

    ✔ idealIntervalFits
    ✔ nonOverlappingIntervals
    ✔ requiredAtStartOfIdeal
    ✔ requiredNearStartOfIdeal
    ✔ requiredNearEndOfIdeal
    ✔ requiredInMiddleOfIdeal
    ✔ negativeIntervals
    ✔ intervalEqualityTest
    ✔ requiredIntervalBarelyFits
    ✔ requiredAtEndOfIdeal
    ✔ equalRequiredAndIdealIntervals

  io.flutter.inspector.FlutterWidgetTest

    ✔ privateClassFilter
    ✔ subcategories
    ✔ allCategories
    ✔ categories
    ✔ combinedPatternFilters
    ✔ patternFilters

  io.flutter.perf.FlutterWidgetPerfTest

    ✔ testFileStatsCalculation
    ✔ testOverallStatsCalculation

  io.flutter.perf.SlidingWindowStatsTest

    ✔ duplicateSlidingWindowStatTimestamps
    ✔ simpleSlidingWindowStats
    ✔ totalSinceNavigation
    ✔ clearSlidingWindowStats

  191 passing (27.3s)
  2 failing


193 tests completed, 2 failed
There were failing tests. See the report at: file:///usr/local/google/home/djshuckerow/Code/github.com/DaveShuckerow/flutter-intellij/build/reports/tests/test/index.html

[stevemessick]

Awesome! We no longer need line 86 in ./build.gradle, which prevents them from running on travis.