Add flag to skip the dart analyzer error check before a hot reload #3414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Apr 25, 2019
| settings.hot.reload.on.save=Perform hot reload on save | ||
| settings.disable.tracking.widget.creation=Disable tracking widget creation locations | ||
| settings.enable.bazel.test.runner=Enable new Bazel test runner | ||
| settings.hot.reload.with.error=Perform hot reload even if there are analysis errors in the project |
There was a problem hiding this comment.
Perhaps, Perform hot reload even if there are analysis errors?
| // If the analysis server detects any errors in the project, it will not perform a hot reload. | ||
| // This can cause hot reload to stop working needlessly when, eg, there is an analysis error in a test file. | ||
| // The reloadWithError option in settings is a workaround. | ||
| if (hasErrors(app.getProject(), app.getModule(), editor.getDocument()) && !mySettings.isReloadWithError()) { |
There was a problem hiding this comment.
Is there an issue tracking a better fix (in flutter_tools)? If so, we could in-line the reference here.
| </constraints> | ||
| <properties> | ||
| <text resource-bundle="io/flutter/FlutterBundle" key="settings.hot.reload.with.error"/> | ||
| <toolTipText value="Hot reload changes into running Flutter apps even with analysis errors."/> |
There was a problem hiding this comment.
Hot reload changes into running Flutter apps even if there are analysis errors?
added 2 commits
April 25, 2019 13:09
stevemessick
pushed a commit
that referenced
this pull request
May 1, 2019
…3414) * Remove the check for analysis errors blocking reloads * Add a settings option to enable or disable reload with error * Hide the hot reload disabling behind a flag * Respond to comments from Devon
alexander-doroshko
pushed a commit
to alexander-doroshko/flutter-intellij
that referenced
this pull request
Jan 24, 2020
…lutter#3414) * Remove the check for analysis errors blocking reloads * Add a settings option to enable or disable reload with error * Hide the hot reload disabling behind a flag * Respond to comments from Devon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the analysis server detects any errors in the project, it will not perform a hot reload.
This can cause hot reload to stop working needlessly when, eg, there is an analysis error in a test file.
Take two on #3181.