Skip to content

Conversation

DaveShuckerow
Copy link
Contributor

Disabling the check that the project has no analysis errors.

Fixes #3168 pending an upstream fix to the Flutter daemon (flutter/flutter#27618).

@devoncarew
Copy link
Member

devoncarew commented Feb 11, 2019

I think we'll want the flutter change in place, and in a more stable release (beta? stable?) before we land something like this.

If we do need to do something short-term, we could add a user preference.

@DaveShuckerow
Copy link
Contributor Author

Agreed. I wanted to have this up so that we can see the change that has to be made.

I'll close this PR until we're ready to actually submit the fix.

DaveShuckerow and others added 21 commits February 11, 2019 18:34
* NewModuleTest passes

* cleanup

* merge
* fetch remote sample index

* update index to current stable
* Update build for 3.3.1

* cleanup

* update changelog
* Fix version incompatibility

* Adjust labels to match reality
* add the ability to install and open DevTools

* review comments
* update the product matrix

* update .travis.yml

* update resources/META-INF/plugin.xml
* Update changelog

* Add plugin icon (flutter#3214)
* support 2018.3.3

* update the changelog
* Run in 2019 EAP debugger

* Update name

* Update tests
* Update changelog

* Add plugin icon (flutter#3214)

* support 2018.3.3 (flutter#3220)

* support 2018.3.3

* update the changelog
@passsy
Copy link

passsy commented Feb 25, 2019

I have flutter as submodule in my project. Whenever I jump into flutter source, the analysis server discovers the flutter submodule and scans all source. It finds errors in /packages/* because the pub packages aren't pulled. The analysis server then prevents my 100% error/warning free app from starting.
I have to close all flutter source files and restart the server.

The whole procedure takes ~30s because the analysis server is so busy scanning the sources.

I'd appreciate a user preference 👍

stevemessick and others added 26 commits April 8, 2019 14:27
* Fix Project Structure menu
* Update plugin tool
* address reported Java lints

* address lints in java vm service library

* review comments
* Add a test to verify correctness of hot reload
* Make EventStreamTest runnable
* clean up to our flutter web support

* remove printlns

* fix inspector npes

* review comments
* Remove the bazel test runner option

* Respond to Devon's comments
@DaveShuckerow
Copy link
Contributor Author

Commit history is somewhat broken; I'm going to open a new pr off of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error check before hot reload will cause reloads to fail if a clean app is in a bigger project with separate failures