Make logic dealing with converting offsets more robust. #3635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only use the converted offsets when the file and the converted offsets disagree. This avoids bugs where we sometimes converted offsets that shouldn't be converted on windows.
stevemessick
approved these changes
Jul 1, 2019
alexander-doroshko
pushed a commit
to alexander-doroshko/flutter-intellij
that referenced
this pull request
Jan 24, 2020
Only use the converted offsets when the file and the converted offsets disagree. This avoids bugs where we sometimes converted offsets that shouldn't be converted on windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only use the converted offsets when the file and the converted
offsets disagree. This avoids bugs where we sometimes converted
offsets that shouldn't be converted on windows.
This fixes #3561