Enable scorecards in intellij repo. #6047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevemessick
approved these changes
Mar 22, 2022
Member
stevemessick
left a comment
stevemessick
left a comment
There was a problem hiding this comment.
Unit tests will fail until the PR I mentioned in the review is merged.
tool/github.sh
Outdated
|
|
||
| # Get packages for the test data. | ||
| (cd flutter-idea/testData/sample_tests; echo "pub get `pwd`"; pub get) | ||
| (cd flutter-idea/testData/sample_tests; echo "pub get `pwd`"; dart pub get) |
Member
There was a problem hiding this comment.
This file has been fixed in a PR awaiting review. If you could add 'dart ' to the two echo commands it would make merging conflict-free after I get the review. Not mandatory, since I can resolve the conflict myself.
tool/github.sh
Outdated
|
|
||
| # Set up the plugin tool. | ||
| (cd tool/plugin; echo "pub get `pwd`"; pub get) | ||
| (cd tool/plugin; echo "pub get `pwd`"; dart pub get) |
Member
|
@godofredoc Do you not have signing configured for this repo? If you don't want to bother, let me know. I can dup this PR and get you to review it, then merge. |
Contributor
Author
I believe I do, let me send an update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to assess the security posture of this repository.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.