[CQ] remove dead GRADLE_SYNC_TOPIC subscriptions #8218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back In 2019, we added some logic to reflectively access a not-yet public
"GRADLE_SYNC_TOPIC"onGradleSyncStatesubscribing a listener that calledGradleUtils.checkDartSupport()on all sync events.Sometime since then, the field has gone away entirely and we are not getting these notifications. What makes this interesting is how our use of reflection masked the failure.
Luckily, an inspection flagged the unsafe check, spamming our logs at runtime:
My first attempt was to fix the cast but I'm glad I embraced the yak shave. "Safe" reflective access in this case would still have obscured the unnecessariness of this code.
Contribution guidelines:
dart format.