Skip to content

Add an ignore problems file for webernecht compatibility problem #8593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2025
Merged

Add an ignore problems file for webernecht compatibility problem #8593

merged 3 commits into from
Oct 27, 2025
+10 −2

Conversation

@helin24
Copy link
Member

@helin24 helin24 commented Oct 27, 2025 •
edited
Loading

Follow up to #8590

This seems at least better than ignoring compatibility problems entirely.

@helin24 helin24 requested review from jwren and pq October 27, 2025 20:18
pq
pq approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

jwren
jwren approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@jwren jwren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @helin24, would it be possible to enable all of the FailureLevel enums with appropriate annotations in the verify-ignore-problems.txt file?

@helin24
Copy link
Member Author

helin24 commented Oct 27, 2025

would it be possible to enable all of the FailureLevel enums with appropriate annotations in the verify-ignore-problems.txt file?

I don't think so, see JetBrains/intellij-platform-gradle-plugin#2046 (comment). Since most of our warnings are API-related, it won't help us much.

@helin24 helin24 added the autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green. label Oct 27, 2025
@auto-submit auto-submit bot merged commit ce144cc into flutter:main Oct 27, 2025
7 checks passed
@helin24 helin24 deleted the ignore-problems2 branch October 27, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pq pq pq approved these changes

@jwren jwren jwren approved these changes

Assignees

No one assigned

Labels

autosubmit When this label is applied to a PR, the PR will be submitted as soon as all checks are green.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@helin24 @pq @jwren