Skip to content

Conversation

@pq
Copy link
Collaborator

@pq pq commented Nov 4, 2025

Follow-up from #8597. Introduces constants.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@pq pq requested a review from helin24 November 4, 2025 03:38
@pq pq mentioned this pull request Nov 4, 2025
1 task
@pq pq changed the title Analytics constants2 [analytics] introduces constants Nov 4, 2025
* "MainToolbar", "EditorPopup", "GoToAction", etc).
*/
@JvmField
val PLACE = StringValue("place")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might expect these to be namespaced, e.g. ACTION_PLACE or AnalyticsConstants.Actions.PLACE

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My sense is that's unneeded since action-ness is encoded in the TYPE property already? Anyway, for sure, let's talk about it and do a full audit before we start actually capturing any data. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah true! Yes, sgtm

@pq pq merged commit 883eb82 into flutter:main Nov 4, 2025
6 of 7 checks passed
@pq pq deleted the analytics_constants2 branch November 4, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants