-
Notifications
You must be signed in to change notification settings - Fork 330
[analytics] initial sendReport API
#8608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/gemini |
1 similar comment
|
/gemini |
|
Thanks for the ping! I've received the |
|
Hmmm I'm not sure if gemini is just taking a while or if something's wrong. BTW should this be moved to the Dart plugin? |
|
Otherwise this LGTM |
|
Ultimately, yeah, I do think this and the whole analytics reporting service should move to the Dart plugin. I don't want to gate it on that though. (Luckily it should be a simple move once the time comes.) |
helin24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the result handling structure; we can use that elsewhere if it's working well.
@gemini-code-assist this is taking a while - perhaps there is an issue with this PR since it was created before we enabled gemini? |
|
Thanks for checking in, @helin24! The |
A jumping off point for a
sendReportimplementation.Next step is to add params and do some experimenting w/ DTD.
You'll note that this handles error conditions a little differently than the other DTD interactions and I'm open to feedback. (In those cases we return futures that will blow up if interrogated. I'm not sure we want to do that here (or even if we'll ever ask?)) Dunno.
Contribution guidelines:
dart format.