build/config/linux/pkg-config.py should not append sysroot paths

[aduskett]

Is there an existing issue for this?

• I have searched the existing issues
• I have read the guide to filing a bug

Steps to reproduce

git clone https://gitlab.com/aduskett/buildroot-flutter.git
cd buildroot-flutter
make flutter_aarch64_defconfig
rm package/flutter-engine/0004-pkg-config.py-do-not-prepend-sysroot-path.patch
make -Otarget -j$(nproc) flutter-engine-depends
make flutter-engine

Actual results

Buildroot uses the standard PKG_CONFIG_SYSROOT_DIR variable, so what the pkg-config.py script is doing doesn't make sense. There is no need to prepend the sysroot, and flutter should let pkg-config use the PKG_CONFIG_SYSROOT_DIR variable.

Without the patch, the pkg-config.py script double prepends the sysroot path.
IE: output/host/.../sysroot/output/host/.../sysroot

Logs

Logs

<!-- Paste your logs here -->

Flutter Doctor output

Doctor output

<!-- Paste your output here -->

[huycozy]

Looks like you are using a custom buildroot to build an embedded engine.

flutter should let pkg-config use the PKG_CONFIG_SYSROOT_DIR variable.

Labeling this issue as a proposal.

[aduskett]

@huycozy Wrong type of Buildroot. http://buildroot.org. It's like Yocto but make files and closer to a firmware generator.

[huycozy]

I misunderstood this. Can you share more details about this? Specifically, which Flutter repository's code should be updated for pkg-config?

[aduskett]

It looks like https://github.com/flutter/buildroot/blob/master/build/config/linux/pkg-config.py#L210

[chinmaygarde]

Is there a patch to go along with this? We don't have the setup to test this so not sure what the next steps are?

[aduskett]

Is there a patch to go along with this? We don't have the setup to test this so not sure what the next steps are?

Yes? It's in the initial report under "Steps to reproduce"