RouteObserver/NavigatorObserver.didPop no longer called on iOS back swipe

[1AlexFix1]

Hello, on master, deb, beta channel didPop no calls, it is bad, because need check screen pop,

final RouteObserver<PageRoute> routeObserver = RouteObserver<PageRoute>();

class _BaseWidgetState extends State<BaseWidget>
    with RouteAware, WidgetsBindingObserver {

@override
  void initState() {
    super.initState();
    WidgetsBinding.instance.addObserver(this);
  }

@override
  void didChangeDependencies() {
    super.didChangeDependencies();
    routeObserver.subscribe(this, ModalRoute.of(context));
  }

  @override
  void didPushNext() {
    super.didPushNext();
    print('didPushNext');
    if (widget.pushNext != null) widget.pushNext();
  }

  @override
  void didPop() {
    super.didPop();
    print('didPop');
    if (widget.pop != null) widget.pop();
  }

  @override
  void didPopNext() {
    super.didPopNext();
    print('didPopNext');
    if (widget.popNext != null) widget.popNext();
  }

  @override
  void didPush() {
    super.didPush();
    print('didPush');
    if (widget.push != null) widget.push();
  }

  @override
  void dispose() {
    routeObserver.unsubscribe(this);
    WidgetsBinding.instance.removeObserver(this);
    super.dispose();
  }

}

I test channel

1. stable
   //push next screen
   flutter: didPushNext
   flutter: didPush
   -----swipe screen(iOS)
   flutter: didPopNext
   flutter: didPop
   -----touch back button (Android)
   flutter: didPopNext
   flutter: didPop

test: successful

2. master
   //push next screen
   flutter: didPushNext
   flutter: didPush
   -----swipe screen(iOS)
   no reaction!!!
   -----touch back button (Android)
   flutter: didPopNext
   flutter: didPop

3. dev
   //push next screen
   flutter: didPushNext
   flutter: didPush
   ----- swipe screen(iOS)
   no reaction!!!
   -----touch back button (Android)
   flutter: didPopNext
   flutter: didPop

4. beta
   //push next screen
   flutter: didPushNext
   flutter: didPush
   -----swipe screen(iOS)
   no reaction!!!
   -----touch back button (Android)
   flutter: didPopNext
   flutter: didPop

Flutter 1.3.12-pre.29 • channel master • https://github.com/flutter/flutter.git
Framework • revision af6e09f (34 hours ago) • 2019-03-18 21:40:21 -0700
Engine • revision 5088735
Tools • Dart 2.2.1 (build 2.2.1-dev.1.0 None)

Running flutter doctor...
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v1.3.14-pre.7, on Mac OS X 10.14.3 18D109, locale ru-RU)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[✓] Android Studio (version 3.3)
[✓] Connected device (1 available)

• No issues found!

[msw333]

Might be related to #28756

[xster]

Can you help us clarify what is the API you're trying to use? Since there are 2 'iOS swipe' mechanism that may be relevant to your described issue.

On the one hand, Flutter itself handles iOS back swipes within the Flutter navigation mechanism. That's related to #28756 but not related to WidgetsBinding etc.

On the other hand, you might be referring to executing an iOS back swipe one level higher on a FlutterViewController part of a UINavigationController that you have in your own native project. And you're manually calling FlutterViewController.popRoute. In that case, it's related to WidgetsBinding.

These 2 things are somewhat orthogonal. What scenario are you referring to?

[1AlexFix1]

Can you help us clarify what is the API you're trying to use? Since there are 2 'iOS swipe' mechanism that may be relevant to your described issue.

On the one hand, Flutter itself handles iOS back swipes within the Flutter navigation mechanism. That's related to #28756 but not related to WidgetsBinding etc.

On the other hand, you might be referring to executing an iOS back swipe one level higher on a FlutterViewController part of a UINavigationController that you have in your own native project. And you're manually calling FlutterViewController.popRoute. In that case, it's related to WidgetsBinding.

These 2 things are somewhat orthogonal. What scenario are you referring to?

I do Navigator.pushNamed then I do the swipe back and I do not get the message about didPop,

[xster]

Thanks for the response. This might be a bug in our documentation for not being clearer. Those are orthogonal mechanisms. WidgetsBinding only observes platform triggered navigations against the ViewController or Activity etc.

To observe the Flutter side Navigator, pass a NavigatorObserver list into the Navigator constructor (or the Material/CupertinoApp etc).

Did I interpret the question correctly?

[1AlexFix1]

Thanks for the response. This might be a bug in our documentation for not being clearer. Those are orthogonal mechanisms. WidgetsBinding only observes platform triggered navigations against the ViewController or Activity etc.

To observe the Flutter side Navigator, pass a NavigatorObserver list into the Navigator constructor (or the Material/CupertinoApp etc).

Did I interpret the question correctly?

I think I understood, I'm sorry, I did not provide the full information in the question (full code), I, of course, pass the routeObserver to MaterialApp, I did everything as in the documentation https: //docs.flutter .io / flutter / widgets / RouteObserver -class.html and everything works fine on a stable branch, but on the remaining 3 branches didpop flutter is not called when swipe, if there was a transition using CupertinoPageRoute, however, if you press the button on android onBack, didPop is called

[msw333]

Thanks for the response. This might be a bug in our documentation for not being clearer. Those are orthogonal mechanisms. WidgetsBinding only observes platform triggered navigations against the ViewController or Activity etc.

To observe the Flutter side Navigator, pass a NavigatorObserver list into the Navigator constructor (or the Material/CupertinoApp etc).

Did I interpret the question correctly?

Can you show us how (example code)? There is no documentation on this. I think most people (including me) do it like this:

final RouteObserver<PageRoute> routeObserver = new RouteObserver<PageRoute>();
main() {..}

MaterialApp(
navigatorObservers: <NavigatorObserver>[routeObserver], ...)

class SingleChatScreenState extends State<SingleChatScreen>
    with RouteAware {...

 void didPop() {
    print('Screen closed');
  }
}