External textures are not working on Android emulators

[amirh]

This regressed in the last week, I'm bisecting.

D/skia    (12710): Shader compilation error                             
D/skia    (12710): ------------------------                             
D/skia    (12710):    1 #version 300 es                                 
D/skia    (12710):    2                                                 
D/skia    (12710):    3 #extension GL_OES_EGL_image_external_essl3 : require
D/skia    (12710):    4 precision mediump float;                        
D/skia    (12710):    5 precision mediump sampler2D;                    
D/skia    (12710):    6 precision mediump samplerExternalOES;           
D/skia    (12710):    7 out mediump vec4 sk_FragColor;                  
D/skia    (12710):    8 uniform samplerExternalOES uTextureSampler_0_Stage0;
D/skia    (12710):    9 in highp vec2 vlocalCoord_Stage0;               
D/skia    (12710):   10 void main() {                                   
D/skia    (12710):   11     mediump vec4 outputColor_Stage0;            
D/skia    (12710):   12     {                                           
D/skia    (12710):   13         outputColor_Stage0 = vec4(1.0);         
Syncing files to device Android SDK built for x86...                    
D/skia    (12710):   14         highp vec2 texCoord;            
D/skia    (12710):   15         texCoord = vlocalCoord_Stage0;                                                     
D/skia    (12710):   16         outputColor_Stage0 = texture(uTextureSampler_0_Stage0, texCoord);                  
D/skia    (12710):   17     }                                                                                      
D/skia    (12710):   18     {                                                                                      
D/skia    (12710):   19         sk_FragColor = outputColor_Stage0;                                                 
D/skia    (12710):   20     }                                                                                      
D/skia    (12710):   21 }                                                                                          
D/skia    (12710):   22                                                                                            
D/skia    (12710): Errors:                                                                                         
D/skia    (12710): ERROR: 0:6: 'samplerExternalOES' : unsupported type                                             

[amirh]

Regression started at the Skia roll flutter/engine#11000 (rolled to the framework in #38559 ).

[amirh]

The regression started at the following Skia commit:
67529b2543 SkSL GLSL generator writes default precision for sampler2D/samplerExternalOS/sampler2DRect

[tvolkert]

@bsalomon

[bsalomon]

I think this ought to fix it:
https://skia-review.googlesource.com/c/skia/+/235279/

@amirh can you test it out?

[jason-simmons]

Tried the Skia patch on an Android emulator and was able to play video in Gallery

[amirh]

The Skia patch landed. We now need to wait for the Skia and engine rollers.

[amirh]

The fix was rolled to the framework in #38729

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.