Skip to content

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Apr 6, 2022

Run flutter update-packages --force-upgrade

Closes: #101224
Closes: #101318
Closes: #101139
Closes: #101358

Pre-launch Checklist

  • [v] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [v] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [v] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • [v] I signed the [CLA].
  • [v] I listed at least one issue that this PR fixes in the description above.
  • [v] I updated/added relevant documentation (doc comments with ///).
  • [v] I added new tests to check the change I am making, or this PR is [test-exempt].
  • [v] All existing and new tests are passing.

@annagrin annagrin requested a review from Piinks as a code owner April 6, 2022 21:20
@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 6, 2022
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I added a suggestion on how to get analysis to pass)

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

@christopherfujino
Copy link
Contributor

Re-ran Mac_ios hot_mode_dev_cycle_macos_target__benchmark

@jmagman jmagman mentioned this pull request Apr 7, 2022
8 tasks
@christopherfujino
Copy link
Contributor

CI pre-submits are blocked on #101542

@keyonghan
Copy link
Contributor

Brough one try bot back up online, and retried the queue task. Now it is running.

@annagrin annagrin merged commit 74944d5 into flutter:master Apr 8, 2022
@christopherfujino
Copy link
Contributor

Brough one try bot back up online, and retried the queue task. Now it is running.

Thanks @keyonghan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

5 participants