Skip to content

Can call ChangeNotifier.hasListeners after disposed #108931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2022
Merged

Can call ChangeNotifier.hasListeners after disposed #108931

merged 1 commit into from
Aug 4, 2022

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Aug 3, 2022

The doc of hasListeners encourage people to call it in removeListener. Since removeListener can be called after dispose, this getter should also relax its check

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 3, 2022
@chunhtai chunhtai requested a review from goderbauer August 3, 2022 22:34
goderbauer
goderbauer approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 4, 2022
@auto-submit auto-submit bot merged commit 6225bea into flutter:master Aug 4, 2022
@rrousselGit
Copy link
Contributor

rrousselGit commented Aug 4, 2022

Just passing by to say that I love these changes!

These asserts have been problematic for a few people before

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
6225bea Can call ChangeNotifier.hasListeners after disposed (flutter/…
dd4c77f 
…flutter#108931)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 5, 2022
@engine-flutter-autoroll
6225bea Can call ChangeNotifier.hasListeners after disposed (flutter/…
5c4128d 
…flutter#108931)
@Jstuff36 Jstuff36 mentioned this pull request Aug 8, 2022
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@chunhtai @camsim99
Can call ChangeNotifier.hasListeners after disposed (flutter#108931)
e7dd6fe
@chunhtai chunhtai mentioned this pull request Aug 10, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chunhtai @rrousselGit @goderbauer